From: Eric S Fraga <e.fraga@ucl.ac.uk>
To: Eric Schulte <schulte.eric@gmail.com>
Cc: "Sébastien Vauban" <wxhgmqzgwmuf@spammotel.com>, emacs-orgmode@gnu.org
Subject: Re: Re: Fontification of blocks
Date: Thu, 03 Feb 2011 20:05:14 +0000 [thread overview]
Message-ID: <87sjw4ubnp.fsf@ucl.ac.uk> (raw)
In-Reply-To: <871v3pp3e3.fsf@gmail.com> (Eric Schulte's message of "Thu, 03 Feb 2011 08:02:19 -0700")
"Eric Schulte" <schulte.eric@gmail.com> writes:
[...]
>
> Hi Seb,
>
> Thanks for sharing this code. I couldn't help myself but to turn it
> into a patch as that has become my favorite way of reviewing new code.
> The resulting patch it attached.
Seb's code worked for me but your patch doesn't unfortunately.
> I noticed a couple of issues in the applied patch (possibly due to a
> transcription error on my part). Namely
Possibly?
> - I believe your default faces only work for white backgrounds
I have a white background and it doesn't work either but did.
> - I didn't notice a change in background for the code blocks
ditto with the patch.
> - it seems that the #+end_src line is fontified but the #+begin_src line
> is not
I have the opposite (!) with your patch.
I'm not sure what is wrong with the patch but there definitely must be
some error unless something else has creeped in with normal org updates
since yesterday.
--
: Eric S Fraga (GnuPG: 0xC89193D8FFFCF67D) in Emacs 24.0.50.1
: using Org-mode version 7.4 (release_7.4.304.g71203.dirty)
next prev parent reply other threads:[~2011-02-03 20:05 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-10 9:02 Fontification of blocks Sébastien Vauban
2010-12-10 11:12 ` David O'Toole
2010-12-13 21:25 ` Sébastien Vauban
2010-12-22 13:36 ` Dan Davison
2010-12-22 14:46 ` Sébastien Vauban
2010-12-13 19:50 ` Eric Schulte
2010-12-13 20:46 ` Sébastien Vauban
2010-12-15 17:22 ` Eric Schulte
2011-02-01 21:04 ` Sébastien Vauban
2011-02-02 7:25 ` Eric S Fraga
2011-02-02 14:34 ` Dan Davison
2011-02-02 20:19 ` Sébastien Vauban
2011-02-07 12:54 ` Dan Davison
2011-02-07 19:55 ` Sébastien Vauban
2011-02-08 19:00 ` Dan Davison
2011-02-08 20:14 ` Sébastien Vauban
2011-02-09 8:40 ` Dan Davison
2011-02-02 22:24 ` Sébastien Vauban
2011-02-02 22:46 ` Eric S Fraga
2011-02-03 15:02 ` Eric Schulte
2011-02-03 19:57 ` Sébastien Vauban
2011-02-03 20:05 ` Eric S Fraga [this message]
2011-02-03 20:44 ` Sébastien Vauban
2011-02-04 9:21 ` Sébastien Vauban
2011-02-04 16:18 ` Eric S Fraga
2011-02-04 20:50 ` Eric Schulte
2011-02-06 8:52 ` Sébastien Vauban
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sjw4ubnp.fsf@ucl.ac.uk \
--to=e.fraga@ucl.ac.uk \
--cc=emacs-orgmode@gnu.org \
--cc=schulte.eric@gmail.com \
--cc=wxhgmqzgwmuf@spammotel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).