From: "Eric Schulte" <schulte.eric@gmail.com>
To: "Sébastien Vauban" <wxhgmqzgwmuf@spammotel.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Re: Fontification of blocks
Date: Fri, 04 Feb 2011 13:50:57 -0700 [thread overview]
Message-ID: <878vxv1q1o.fsf@gmail.com> (raw)
In-Reply-To: 80vd10noj5.fsf@missioncriticalit.com
Hi Seb,
This looks very nice, I am now able to turn fontification on and off as
expected using your three new faces. I've just committed your patch
with one minor change (not having the block background face set by
default).
Maybe it would be worth a worg post about how to use these faces with
some example settings...
Thanks -- Eric
Sébastien Vauban <wxhgmqzgwmuf@spammotel.com> writes:
> Hi,
>
> As spotted by Eric Fraga:
>
> Sébastien Vauban wrote:
>> --- a/lisp/org-faces.el
>> +++ b/lisp/org-faces.el
>> @@ -1,6 +1,6 @@
>> ;;; org-faces.el --- Face definitions for Org-mode.
>>
>> -;; Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010
>> +;; Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011
>> ;; Free Software Foundation, Inc.
>>
>> ;; Author: Carsten Dominik <carsten at orgmode dot org>
>> @@ -511,6 +511,16 @@ follows a #+DATE:, #+AUTHOR: or #+EMAIL: keyword."
>> :group 'org-faces
>> :version "22.1")
>>
>> +(defface org-block-background
>> + '((t (:background "#FFFFEA")))
>> + "Face used for the source block background.")
>> +
>> +(org-copy-face 'org-meta-line 'org-block-begin-line
>> + "Face used for the line delimiting the begin of source blocks.")
>> +
>> +(org-copy-face 'org-meta-line 'org-block-begin-line
>> + "Face used for the line delimiting the end of source blocks.")
>> +
>> (defface org-verbatim
>> (org-compatible-face 'shadow
>> '((((class color grayscale) (min-colors 88) (background light))
>
> you should read the following at the 2nd =org-copy-face= command:
>
>> +(org-copy-face 'org-meta-line 'org-block-end-line
>> + "Face used for the line delimiting the end of source blocks.")
>
> ie, s/begin/end/
>
> I guess it worked for me (I restarted completely Emacs for the test), as that
> face is defined in my color-theme now. So, it was created anyway.
>
> Corrected patch is attached to this post.
>
> Best regards,
> Seb
next prev parent reply other threads:[~2011-02-04 20:51 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-10 9:02 Fontification of blocks Sébastien Vauban
2010-12-10 11:12 ` David O'Toole
2010-12-13 21:25 ` Sébastien Vauban
2010-12-22 13:36 ` Dan Davison
2010-12-22 14:46 ` Sébastien Vauban
2010-12-13 19:50 ` Eric Schulte
2010-12-13 20:46 ` Sébastien Vauban
2010-12-15 17:22 ` Eric Schulte
2011-02-01 21:04 ` Sébastien Vauban
2011-02-02 7:25 ` Eric S Fraga
2011-02-02 14:34 ` Dan Davison
2011-02-02 20:19 ` Sébastien Vauban
2011-02-07 12:54 ` Dan Davison
2011-02-07 19:55 ` Sébastien Vauban
2011-02-08 19:00 ` Dan Davison
2011-02-08 20:14 ` Sébastien Vauban
2011-02-09 8:40 ` Dan Davison
2011-02-02 22:24 ` Sébastien Vauban
2011-02-02 22:46 ` Eric S Fraga
2011-02-03 15:02 ` Eric Schulte
2011-02-03 19:57 ` Sébastien Vauban
2011-02-03 20:05 ` Eric S Fraga
2011-02-03 20:44 ` Sébastien Vauban
2011-02-04 9:21 ` Sébastien Vauban
2011-02-04 16:18 ` Eric S Fraga
2011-02-04 20:50 ` Eric Schulte [this message]
2011-02-06 8:52 ` Sébastien Vauban
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878vxv1q1o.fsf@gmail.com \
--to=schulte.eric@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=wxhgmqzgwmuf@spammotel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).