[PATCH] - Fix org-fast-tag-selection

[PATCH] - Fix org-fast-tag-selection

[Noorul Islam K M]

[-- Attachment #1: Type: text/plain, Size: 1876 bytes --]


Hello all,

I have the following setup similar to Bernt Hansen.

(setq org-tag-alist (quote ((:startgroup)
                            ("@errand" . ?e)
                            ("@office" . ?o)
                            ("@home" . ?h)
                            (:endgroup)
                            ("PHONE" . ?p)
                            ("WAITING" . ?w)
                            ("HOME" . ?H)
                            ("CANCELLED" . ?c)
                            ("NOTE" . ?n)
                            ("ORG" . ?O))))

New when I try to add a new tag with the key press "C-c C-q TAB" from a
heading, I get following backtrace.

Debugger entered--Lisp error: (wrong-type-argument stringp :endgroup)
  string-match("" :endgroup)
  ido-read-internal(list "Tag: " nil nil nil nil)
  ido-completing-read("Tag: " (#("REFILE" 0 6 (inherited t)) :startgroup "@errand" "@office" "@home" :endgroup "PHONE" "WAITING" "HOME" "CANCELLED" "NOTE" "ORG"))
  apply(ido-completing-read "Tag: " (#("REFILE" 0 6 (inherited t)) :startgroup "@errand" "@office" "@home" :endgroup "PHONE" "WAITING" "HOME" "CANCELLED" "NOTE" "ORG") nil)
  org-icompleting-read("Tag: " (#("REFILE" 0 6 (inherited t)) :startgroup "@errand" "@office" "@home" :endgroup "PHONE" "WAITING" "HOME" "CANCELLED" "NOTE" "ORG"))
  org-fast-tag-selection(nil (#("REFILE" 0 6 (inherited t))) ((:startgroup) ("@errand" . 101) ("@office" . 111) ("@home" . 104) (:endgroup) ("PHONE" . 112) ("WAITING" . 119) ("HOME" . 72) ("CANCELLED" . 99) ("NOTE" . 110) ("ORG" . 79) (#("REFILE" 0 6 (inherited t)))) nil)
  org-set-tags(nil nil)
  org-set-tags-command(nil)
  call-interactively(org-set-tags-command nil nil)

I think I nailed down the problem and fixed it in the attached patch.

Changelog:

* lisp/org.el (org-fast-tag-selection): Remove non-string object from org-tag-alist.

Thanks and Regards
Noorul


[-- Attachment #2: org.el.todo.fast.selection.txt --]
[-- Type: text/plain, Size: 573 bytes --]

diff --git a/lisp/org.el b/lisp/org.el
index 8ffb6c8..2df860e 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -13756,7 +13756,10 @@ Returns the new tags string, or nil to not change the current settings."
 				 (append (or buffer-tags
 					     (with-current-buffer buf
 					       (mapcar 'car (org-get-buffer-tags))))
-					 (mapcar 'car table)))))
+					 (delq nil 
+					       (mapcar (lambda (x) 
+							 (if (stringp 
+							      (car x)) x)) table))))))
 		    (quit (setq tg "")))
 		  (when (string-match "\\S-" tg)
 		    (add-to-list 'buffer-tags (list tg))

Re: [PATCH] - Fix org-fast-tag-selection

[Bastien]

Hi Noorul,

Noorul Islam K M <noorul@noorul.com> writes:

> I think I nailed down the problem and fixed it in the attached patch.

Applied, thanks a lot!

-- 
 Bastien

Re: [PATCH] - Fix org-fast-tag-selection

[Noorul Islam Kamal Malmiyoda]

[-- Attachment #1: Type: text/plain, Size: 530 bytes --]

On Tuesday, April 3, 2012, Bastien <bzgNOSPAM@altern.org> wrote:
> Hi Noorul,
>
> Noorul Islam K M <noorul@noorul.com> writes:
>
>> I think I nailed down the problem and fixed it in the attached patch.
>
> Applied, thanks a lot!

Can you please let me know why this commit does not have me as the author?
I already signed papers and there are some commits from my side already.
This happened earlier also when you said that the patch was not carrying
commit log. I think this time there was change log.

Thanks and regards
Noorul

[-- Attachment #2: Type: text/html, Size: 700 bytes --]

Re: [PATCH] - Fix org-fast-tag-selection

[Bastien]

Noorul Islam Kamal Malmiyoda <noorul@noorul.com> writes:

> Can you please let me know why this commit does not have me as the
> author? I already signed papers and there are some commits from my
> side already. 

This is an error, sorry.

> This happened earlier also when you said that the patch
> was not carrying commit log. I think this time there was change log.

The ChangeLog should have been included in the patch,
it was not.  Please use git format-patch when possible.

http://orgmode.org/worg/org-contribute.html#sec-5

Do you want me to revert the commit and to redo one with your name?

-- 
 Bastien

Re: [PATCH] - Fix org-fast-tag-selection

[Noorul Islam Kamal Malmiyoda]

[-- Attachment #1: Type: text/plain, Size: 747 bytes --]

On Tuesday, April 3, 2012, Bastien <bzg@altern.org> wrote:
> Noorul Islam Kamal Malmiyoda <noorul@noorul.com> writes:
>
>> Can you please let me know why this commit does not have me as the
>> author? I already signed papers and there are some commits from my
>> side already.
>
> This is an error, sorry.

No problem

>
>> This happened earlier also when you said that the patch
>> was not carrying commit log. I think this time there was change log.
>
> The ChangeLog should have been included in the patch,
> it was not.  Please use git format-patch when possible.
>
> http://orgmode.org/worg/org-contribute.html#sec-5
>
> Do you want me to revert the commit and to redo one with your name?

Not necessary this time.

Thanks and Regards
Noorul

[-- Attachment #2: Type: text/html, Size: 1060 bytes --]

Re: [PATCH] - Fix org-fast-tag-selection

[Bastien]

Noorul Islam Kamal Malmiyoda <noorul@noorul.com> writes:

> Not necessary this time.

Okay, thanks.

I amended http://orgmode.org/worg/org-contribute.html to explain why
patches made with `git format-patch' are always preferred, even small
patches.

I'm less and less using Patchwork as a way to apply patches, because I
find commit messages to be sometimes messy that way.

Instead, I have local folders with patches I want to apply/review/etc.
I patch Org using `git apply' when I want to test, `git am' when I want
to commit a properly formatted patch.

It means that for each patch that doesn't have a ChangeLog, I have to 
(1) add it myself and (2) manually use git commit --author="<author>"
to have the correct author displayed.

To summarize, whether the patch is *small or big* is not the right
criterium to decide whether a simple `git diff' is acceptable -- it's
more about whether the patch is sent for testing purpose first, or
whether it is considered applicable as such.

Thanks!

-- 
 Bastien

Re: [PATCH] - Fix org-fast-tag-selection

[Nick Dokos]

Noorul Islam K M <noorul@noorul.com> wrote:

> 
> Hello all,
> 
> I have the following setup similar to Bernt Hansen.
> 
> (setq org-tag-alist (quote ((:startgroup)
>                             ("@errand" . ?e)
>                             ("@office" . ?o)
>                             ("@home" . ?h)
>                             (:endgroup)
>                             ("PHONE" . ?p)
>                             ("WAITING" . ?w)
>                             ("HOME" . ?H)
>                             ("CANCELLED" . ?c)
>                             ("NOTE" . ?n)
>                             ("ORG" . ?O))))
> 
> New when I try to add a new tag with the key press "C-c C-q TAB" from a
> heading, I get following backtrace.
> 
> Debugger entered--Lisp error: (wrong-type-argument stringp :endgroup)
>   string-match("" :endgroup)
>   ido-read-internal(list "Tag: " nil nil nil nil)
>   ido-completing-read("Tag: " (#("REFILE" 0 6 (inherited t)) :startgroup "@errand" "@office" "@home" :endgroup "PHONE" "WAITING" "HOME" "CANCELLED" "NOTE" "ORG"))
>   apply(ido-completing-read "Tag: " (#("REFILE" 0 6 (inherited t)) :startgroup "@errand" "@office" "@home" :endgroup "PHONE" "WAITING" "HOME" "CANCELLED" "NOTE" "ORG") nil)
>   org-icompleting-read("Tag: " (#("REFILE" 0 6 (inherited t)) :startgroup "@errand" "@office" "@home" :endgroup "PHONE" "WAITING" "HOME" "CANCELLED" "NOTE" "ORG"))
>   org-fast-tag-selection(nil (#("REFILE" 0 6 (inherited t))) ((:startgroup) ("@errand" . 101) ("@office" . 111) ("@home" . 104) (:endgroup) ("PHONE" . 112) ("WAITING" . 119) ("HOME" . 72) ("CANCELLED" . 99) ("NOTE" . 110) ("ORG" . 79) (#("REFILE" 0 6 (inherited t)))) nil)
>   org-set-tags(nil nil)
>   org-set-tags-command(nil)
>   call-interactively(org-set-tags-command nil nil)
> 
> I think I nailed down the problem and fixed it in the attached patch.
> 

Why did the :endgroup fail and not the :startgroup?

Nick

> Changelog:
> 
> * lisp/org.el (org-fast-tag-selection): Remove non-string object from org-tag-alist.
> 
> Thanks and Regards
> Noorul
> 
> diff --git a/lisp/org.el b/lisp/org.el
> index 8ffb6c8..2df860e 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -13756,7 +13756,10 @@ Returns the new tags string, or nil to not change the current settings."
>  				 (append (or buffer-tags
>  					     (with-current-buffer buf
>  					       (mapcar 'car (org-get-buffer-tags))))
> -					 (mapcar 'car table)))))
> +					 (delq nil 
> +					       (mapcar (lambda (x) 
> +							 (if (stringp 
> +							      (car x)) x)) table))))))
>  		    (quit (setq tg "")))
>  		  (when (string-match "\\S-" tg)
>  		    (add-to-list 'buffer-tags (list tg))

Re: [PATCH] - Fix org-fast-tag-selection

[Bernt Hansen]

Noorul Islam K M <noorul@noorul.com> writes:

> Hello all,
>
> I have the following setup similar to Bernt Hansen.
>
> (setq org-tag-alist (quote ((:startgroup)
>                             ("@errand" . ?e)
>                             ("@office" . ?o)
>                             ("@home" . ?h)
>                             (:endgroup)
>                             ("PHONE" . ?p)
>                             ("WAITING" . ?w)
>                             ("HOME" . ?H)
>                             ("CANCELLED" . ?c)
>                             ("NOTE" . ?n)
>                             ("ORG" . ?O))))
>
> New when I try to add a new tag with the key press "C-c C-q TAB" from a
> heading, I get following backtrace.
>
> Debugger entered--Lisp error: (wrong-type-argument stringp :endgroup)

I get the same error but I didn't notice since I rarely use C-c C-q TAB.

Regards,
Bernt

Re: [PATCH] - Fix org-fast-tag-selection

[Nick Dokos]

Bernt Hansen <bernt@norang.ca> wrote:

> Noorul Islam K M <noorul@noorul.com> writes:
> 
> > Hello all,
> >
> > I have the following setup similar to Bernt Hansen.
> >
> > (setq org-tag-alist (quote ((:startgroup)
> >                             ("@errand" . ?e)
> >                             ("@office" . ?o)
> >                             ("@home" . ?h)
> >                             (:endgroup)
> >                             ("PHONE" . ?p)
> >                             ("WAITING" . ?w)
> >                             ("HOME" . ?H)
> >                             ("CANCELLED" . ?c)
> >                             ("NOTE" . ?n)
> >                             ("ORG" . ?O))))
> >
> > New when I try to add a new tag with the key press "C-c C-q TAB" from a
> > heading, I get following backtrace.
> >
> > Debugger entered--Lisp error: (wrong-type-argument stringp :endgroup)
> 
> I get the same error but I didn't notice since I rarely use C-c C-q TAB.
> 

I'm still not clear why the error happens with :endgroup and not with :startgroup.

There is also the question of which completion mechanism one is using: Noorul seems
to be using ido and that may have something to do with the order in which errors are
found. I am just using the default completing-read mechanism and I get a different
error (even with Noorul's fix, which leads me to believe that there are multiple
problems). I have not tried the iswitchb mechanism.

With completing-read, I do C-c C-q <TAB> and get a prompt in the minibuffer "Tag: "
with no options given. So I press another <TAB> and get the following error:

Debugger entered--Lisp error: (invalid-function (:startgroup "@errand" "@office" "@home" :endgroup "PHONE" "WAITING" "HOME" "CANCELLED" "NOTE" "ORG"))
  signal(invalid-function ((:startgroup "@errand" "@office" "@home" :endgroup "PHONE" "WAITING" "HOME" "CANCELLED" "NOTE" "ORG")))
  completion--some(#[257 "\211\f\236A@\300\301\302\303$\207" ["P" (:startgroup "@errand" "@office" "@home" :endgroup "PHONE" "WAITING" "HOME" "CANCELLED" "NOTE" "ORG") nil 1 completion-styles-alist] 6 "\n\n(fn STYLE)"] (basic partial-completion emacs22))
  completion-try-completion("P" (:startgroup "@errand" "@office" "@home" :endgroup "PHONE" "WAITING" "HOME" "CANCELLED" "NOTE" "ORG") nil 1 (metadata))
  completion--do-completion()
  minibuffer-complete()
  call-interactively(minibuffer-complete nil nil)
  read-from-minibuffer("Tag: " nil (keymap (menu-bar keymap (minibuf "Minibuf" keymap (tab menu-item "Complete" minibuffer-complete :help "Complete as far as possible") (space menu-item "Complete Word" minibuffer-complete-word :help "Complete at most one word") (63 menu-item "List Completions" minibuffer-completion-help :help "Display all possible completions") "Minibuf")) (27 keymap (118 . switch-to-completions)) (prior . switch-to-completions) (63 . minibuffer-completion-help) (32 . minibuffer-complete-word) (9 . minibuffer-complete) keymap (menu-bar keymap (minibuf "Minibuf" keymap (previous menu-item "Previous History Item" previous-history-element :help "Put previous minibuffer history element in the minibuffer") (next menu-item "Next History Item" next-history-element :help "Put next
  minibuffer history element in the minibuffer") (isearch-backward menu-item "Isearch History Backward" isearch-backward :help "Incrementally search minibuffer history backward") (isearch-for
 ward menu-item "Isearch History Forward" isearch-forward :help "Incrementally search minibuffer history forward") (return menu-item "Enter" exit-minibuffer :key-sequence "
" :help "Terminate input and exit minibuffer") (quit menu-item "Quit" abort-recursive-edit :help "Abort input and exit minibuffer") "Minibuf")) (10 . exit-minibuffer) (13 . exit-minibuffer) (7 . abort-recursive-edit) (C-tab . file-cache-minibuffer-complete) (9 . self-insert-command) (up . previous-history-element) (prior . previous-history-element) (down . next-history-element) (next . next-history-element) (27 keymap (114 . previous-matching-history-element) (115 . next-matching-history-element) (112 . previous-history-element) (110 . next-history-element))) nil nil nil nil)
  completing-read-default("Tag: " (:startgroup "@errand" "@office" "@home" :endgroup "PHONE" "WAITING" "HOME" "CANCELLED" "NOTE" "ORG") nil nil nil nil nil nil)
  completing-read("Tag: " (:startgroup "@errand" "@office" "@home" :endgroup "PHONE" "WAITING" "HOME" "CANCELLED" "NOTE" "ORG") nil nil nil nil nil nil)
  apply(completing-read ("Tag: " (:startgroup "@errand" "@office" "@home" :endgroup "PHONE" "WAITING" "HOME" "CANCELLED" "NOTE" "ORG")))
  org-icompleting-read("Tag: " (:startgroup "@errand" "@office" "@home" :endgroup "PHONE" "WAITING" "HOME" "CANCELLED" "NOTE" "ORG"))
  byte-code("\304\305\306\307\b\206\x12

Re: [PATCH] - Fix org-fast-tag-selection

[Bastien]

Hi Nick,

Nick Dokos <nicholas.dokos@hp.com> writes:

> With completing-read, I do C-c C-q <TAB> and get a prompt in the
> minibuffer "Tag: " with no options given. So I press another <TAB> and
> get the following error:

This should have been fixed already -- can you confirm?

Thanks,

-- 
 Bastien

Re: [PATCH] - Fix org-fast-tag-selection

[Bernt Hansen]

Bastien <bzg@gnu.org> writes:

> Hi Nick,
>
> Nick Dokos <nicholas.dokos@hp.com> writes:
>
>> With completing-read, I do C-c C-q <TAB> and get a prompt in the
>> minibuffer "Tag: " with no options given. So I press another <TAB> and
>> get the following error:
>
> This should have been fixed already -- can you confirm?

Hi Bastien,

This error is gone but I see other problems.

When completing tags with C-c C-q TAB and selecting a tag that is part
of a group which are supposed to be mutually exclusive it doesn't
remove other existing tags in that group.

ie.

* DONE Test                                                           :@home:

with

(setq org-tag-alist (quote ((:startgroup)
                            ("@errand" . ?e)
                            ("@office" . ?o)
                            ("@home" . ?H)
                            ("@farm" . ?f)
                            (:endgroup)
                            ("PHONE" . ?p)
                            ("WAITING" . ?w)
                            ("HOLD" . ?h)
                            ("PERSONAL" . ?P)
                            ("WORK" . ?W)
                            ("FARM" . ?F)
                            ("ORG" . ?O)
                            ("NORANG" . ?N)
                            ("crypt" . ?E)
                            ("MARK" . ?M)
                            ("NOTE" . ?n)
                            ("BZFLAG" . ?B)
                            ("CANCELLED" . ?c)
                            ("FLAGGED" . ??))))
if I do C-c C-q f
then @home changes to @farm as it should

But if I instead complete the tag with

C-C C-q TAB @farm RET

then I get BOTH tags on the line which is wrong.

* DONE Test                                                     :@farm:@home:

Org-mode version 7.8.08 (release_7.8.07.206.g76e7b)

Also my IDO completion of tags doesn't work (but I'm not sure if that
ever did).  I can't to C-c C-q TAB home RET and get the @home tag -- I
need to enter the @ for it to work.  Without the @ I get errors like
this:

Error in post-command-hook: (wrong-type-argument sequencep 104)

when what I enter doesn't match my tag list.

Regards,
Bernt

Re: [PATCH] - Fix org-fast-tag-selection

[Nick Dokos]

Bernt Hansen <bernt@norang.ca> wrote:

> Bastien <bzg@gnu.org> writes:
> 
> > Hi Nick,
> >
> > Nick Dokos <nicholas.dokos@hp.com> writes:
> >
> >> With completing-read, I do C-c C-q <TAB> and get a prompt in the
> >> minibuffer "Tag: " with no options given. So I press another <TAB> and
> >> get the following error:
> >
> > This should have been fixed already -- can you confirm?
> 

> This error is gone ...

Confirmed.

Nick

Re: [PATCH] - Fix org-fast-tag-selection

[Bastien]

Hi Bernt,

Bernt Hansen <bernt@norang.ca> writes:

> This error is gone but I see other problems.
>
> When completing tags with C-c C-q TAB and selecting a tag that is part
> of a group which are supposed to be mutually exclusive it doesn't
> remove other existing tags in that group.

This error was introduced by the commits I push to fix Mike's issue.  

It should be gone now.

I reverted these commits and things are now back to the previous
behavior.   

> Also my IDO completion of tags doesn't work (but I'm not sure if that
> ever did).  I can't to C-c C-q TAB home RET and get the @home tag -- I
> need to enter the @ for it to work.  Without the @ I get errors like
> this:
>
> Error in post-command-hook: (wrong-type-argument sequencep 104)
>
> when what I enter doesn't match my tag list.

This should not happen anymore too.

Best,

-- 
 Bastien