emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Bastien <bzg@gnu.org>
To: Noorul Islam Kamal Malmiyoda <noorul@noorul.com>
Cc: emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] - Fix org-fast-tag-selection
Date: Tue, 03 Apr 2012 16:29:11 +0200	[thread overview]
Message-ID: <8762dgkhxk.fsf@gnu.org> (raw)
In-Reply-To: <CA+H4GH_Hfc=w8qOEsethU7WG-EAZ2gJR1da_SgburJzYZq3TPg@mail.gmail.com> (Noorul Islam Kamal Malmiyoda's message of "Tue, 3 Apr 2012 19:32:21 +0530")

Noorul Islam Kamal Malmiyoda <noorul@noorul.com> writes:

> Not necessary this time.

Okay, thanks.

I amended http://orgmode.org/worg/org-contribute.html to explain why
patches made with `git format-patch' are always preferred, even small
patches.

I'm less and less using Patchwork as a way to apply patches, because I
find commit messages to be sometimes messy that way.

Instead, I have local folders with patches I want to apply/review/etc.
I patch Org using `git apply' when I want to test, `git am' when I want
to commit a properly formatted patch.

It means that for each patch that doesn't have a ChangeLog, I have to 
(1) add it myself and (2) manually use git commit --author="<author>"
to have the correct author displayed.

To summarize, whether the patch is *small or big* is not the right
criterium to decide whether a simple `git diff' is acceptable -- it's
more about whether the patch is sent for testing purpose first, or
whether it is considered applicable as such.

Thanks!

-- 
 Bastien

next prev parent reply	other threads:[~2012-04-03 14:28 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-03 10:43 [PATCH] - Fix org-fast-tag-selection Noorul Islam K M
2012-04-03 12:10 ` Bastien
2012-04-03 13:48   ` Noorul Islam Kamal Malmiyoda
2012-04-03 13:57     ` Bastien
2012-04-03 14:02       ` Noorul Islam Kamal Malmiyoda
2012-04-03 14:29         ` Bastien [this message]
2012-04-03 13:45 ` Nick Dokos
2012-04-03 16:13 ` Bernt Hansen
2012-04-03 21:42   ` Nick Dokos
2012-04-04  5:56     ` Bastien
2012-04-04 11:16       ` Bernt Hansen
2012-04-04 13:54         ` Nick Dokos
2012-04-10 16:41         ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8762dgkhxk.fsf@gnu.org \
    --to=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=noorul@noorul.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).