From: Ihor Radchenko <yantar92@gmail.com>
To: Max Nikulin <manikulin@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] ob-plantuml: Allow setting PlantUML args for jar file
Date: Sun, 08 May 2022 14:48:57 +0800 [thread overview]
Message-ID: <874k20v7s6.fsf@localhost> (raw)
In-Reply-To: <ssk114$hhb$1@ciao.gmane.io>
Max Nikulin <manikulin@gmail.com> writes:
> To wrap up, I suggest (and I do not insist) to drop
> "-Djava.awt.headless=true" since "-headless" is anyway added in jar
> mode. Those who desperately need namely "-Djava.awt.headless=true" (for
> some unknown to me reason) may customize :java header argument. I do not
> see any real problem with the change, just a minor improvement.
After further consideration, I decided to follow your suggestion.
If we insist of -Djava.awt.headless=true in org-plantuml-exec-mode='jar
but not in 'plantuml, we may run into inconsistency between users using
the two alternatives.
Applied onto main as b5f0efc04.
Best,
Ihor
next prev parent reply other threads:[~2022-05-08 6:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-03 22:56 ob-plantuml: Proposal to add 'jar-args' customizable variable Dejan Josifović
2022-01-06 19:53 ` Dejan Josifović
2022-01-07 4:38 ` Ihor Radchenko
2022-01-08 13:14 ` Dejan Josifović
2022-01-09 17:46 ` Andy Moreton
2022-01-10 16:00 ` Dejan Josifović
2022-01-15 6:20 ` [PATCH] ob-plantuml: Allow setting PlantUML args for jar file Ihor Radchenko
2022-01-16 7:53 ` Max Nikulin
2022-01-17 17:19 ` Dejan Josifović
2022-01-18 13:30 ` Ihor Radchenko
2022-01-19 16:54 ` Max Nikulin
2022-01-21 12:48 ` Ihor Radchenko
2022-01-23 16:50 ` Max Nikulin
2022-05-08 6:48 ` Ihor Radchenko [this message]
2022-01-21 22:22 ` Dejan Josifović
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874k20v7s6.fsf@localhost \
--to=yantar92@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=manikulin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).