From: Ihor Radchenko <email@example.com>
To: "Dejan Josifović" <firstname.lastname@example.org>
Cc: Max Nikulin <email@example.com>, firstname.lastname@example.org
Subject: Re: [PATCH] ob-plantuml: Allow setting PlantUML args for jar file
Date: Tue, 18 Jan 2022 21:30:14 +0800 [thread overview]
Message-ID: <87lezdnpcp.fsf@localhost> (raw)
Dejan Josifović <email@example.com> writes:
> But, since ob-plantuml already had variable for arguments for executable
> it fells natural to me to have customizable variables for when using
> jar. These headers are of course easier, but the user would have to
> write them on each source block to achieve something that should be
> globally customizable (like charset).
FYI, you can customise any header arg globally. See manual page 16.3
Using Header Arguments.
> I second the concern that Max stated:
>> Is there a case when some arguments are suitable for dedicated binary but should be avoided for jar (when a user has both executable from system package and manually downloaded jar having newer version)? It may be a reason to have separate variables (or header arguments).
> I believe it is better design decision to separate arguments for
> executable and jar.
I am not sure about this specific case. The PlantUML executable is
literally a wrapper around java call to jar. Below is the contents of
plantuml file in my system:
Unless it is any different on your side, the arguments for jar and
executable should be literally the same.
> Since we are making jar arguments customizable, we should think about
> adding java arguments customizable (also mentioned by Max!). This line
> in patch:
> + "-Djava.awt.headless=true"
> can be also added to a separate variable.
I feel that running headless mode in the ob-plantuml is deliberate. We
may not want users to change it. Otherwise, you are free to customize
java arguments in org-babel-default-header-args:plantuml
> Lastly, there is a typo in the patch:
> +** Removed or renamed functions and variables
> +*** =org-plantump-executable-args= is renamed and applies to jar as well
> +The new variable name is =org-plantump-args=. It now applies to both
> +jar PlantUML file and executable.
> Word plantump should be plantuml I guess. :-)
Thanks! Will fix.
next prev parent reply other threads:[~2022-01-18 14:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-03 22:56 ob-plantuml: Proposal to add 'jar-args' customizable variable Dejan Josifović
2022-01-06 19:53 ` Dejan Josifović
2022-01-07 4:38 ` Ihor Radchenko
2022-01-08 13:14 ` Dejan Josifović
2022-01-09 17:46 ` Andy Moreton
2022-01-10 16:00 ` Dejan Josifović
2022-01-15 6:20 ` [PATCH] ob-plantuml: Allow setting PlantUML args for jar file Ihor Radchenko
2022-01-16 7:53 ` Max Nikulin
2022-01-17 17:19 ` Dejan Josifović
2022-01-18 13:30 ` Ihor Radchenko [this message]
2022-01-19 16:54 ` Max Nikulin
2022-01-21 12:48 ` Ihor Radchenko
2022-01-23 16:50 ` Max Nikulin
2022-05-08 6:48 ` Ihor Radchenko
2022-01-21 22:22 ` Dejan Josifović
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).