emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: "Dejan Josifović" <www.paranoidtimes@gmail.com>
To: emacs-orgmode@gnu.org
Subject: ob-plantuml: Proposal to add 'jar-args' customizable variable
Date: Fri, 3 Dec 2021 23:56:40 +0100	[thread overview]
Message-ID: <5d7eba13-b717-a12a-5f89-7d2c9414917e@gmail.com> (raw)

Hi all,

I use PlantUML integration in org-mode for years now, but only
recently I came across some unwanted behavior.

Using PlantUML from jar (org-plantuml-jar-path variable) and latest 
org-mode, I wanted to render a diagram containing some Unicode 
characters (such as '⊥' and '∀'), but the end image had some gibberish 
instead. However,
trying this from a standalone file using plantuml-mode[1], the end image 
rendered correctly. Here is some sample code which can reproduce the issue:

#+BEGIN_SRC plantuml :file ./test.png
A -> B: ∀ characters display correctly is ⊥

Comparing ob-plantuml.el and plantuml-mode.el files I found what is the 
problem. plantuml-mode has a customizable variable for specifying 
arguments when using PlantUML from jar (plantuml-jar-args (list 
"-charset" "UTF-8" ). The charset arguments is what is needed for
the images to render correctly (I confirmed it by implementing it locally).

I was wondering why such variable doesn't exist in ob-plantuml. I have
searched the mailing list archives, confirmed bugs and help page and 
couldn't find anything related.

Does anyone from the community know if such variable was deliberately 
omitted? If so, what is the reason?

If this is indeed a wanted feature, I will be more than happy to provide 
a patch.

[1] https://github.com/skuro/plantuml-mode

Thanks and regards,

Dejan Josifović | Дејан Јосифовић
Software engineer | Софтверски инжењер

()  ascii ribbon campaign
/\  www.asciiribbon.org

             reply	other threads:[~2021-12-03 22:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-03 22:56 Dejan Josifović [this message]
2022-01-06 19:53 ` ob-plantuml: Proposal to add 'jar-args' customizable variable Dejan Josifović
2022-01-07  4:38   ` Ihor Radchenko
2022-01-08 13:14     ` Dejan Josifović
2022-01-09 17:46 ` Andy Moreton
2022-01-10 16:00   ` Dejan Josifović
2022-01-15  6:20 ` [PATCH] ob-plantuml: Allow setting PlantUML args for jar file Ihor Radchenko
2022-01-16  7:53   ` Max Nikulin
2022-01-17 17:19     ` Dejan Josifović
2022-01-18 13:30       ` Ihor Radchenko
2022-01-19 16:54         ` Max Nikulin
2022-01-21 12:48           ` Ihor Radchenko
2022-01-23 16:50             ` Max Nikulin
2022-05-08  6:48               ` Ihor Radchenko
2022-01-21 22:22           ` Dejan Josifović

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5d7eba13-b717-a12a-5f89-7d2c9414917e@gmail.com \
    --to=www.paranoidtimes@gmail.com \
    --cc=emacs-orgmode@gnu.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).