Re: [PATCH] ob-sql: Add support for Athena

[Ihor Radchenko <yantar92@posteo.net>]

Daniel Kraus <daniel@kraus.my> writes:

> I'm using this patch since a few month that adds support
> for AWS Athena.
> The only thing that's maybe against adding it is that
> `athenacli` (https://github.com/dbcli/athenacli) is not an
> official AWS tool but just a Python script.
>
> What's the opinion on this?

Is this something commonly used?

I see two main issues with the idea:
1. I do not like the idea of adding all the possible CLI tools over
   there in ad-hoc manner. It would be cleaner to provide a
   customization to add various cli tools in a defcustom/defvar without
   manually changing the functions.

2. I feel like it will be hard to maintain such unpopular clients. If
   (1) is addressed + good automatic tests are implemented, things may
   be acceptable for inclusion though.

In summary, I am not against the idea of including a new sql cli, but we
should better provide a centralized API to do so and make sure that we
have test coverage, making sure that things are not broken in future,
when the original committer is gone and nobody else is left familiar
with specific obscure SQL client.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>