From: Tim Cross <theophilusx@gmail.com>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: rms@gnu.org, Jean Louis <bugs@gnu.support>, emacs-orgmode@gnu.org
Subject: Re: Supporting non-free SQL clients in ob-sql (was: [PATCH] ob-sql: Add support for Athena)
Date: Thu, 26 Jan 2023 01:05:58 +1100 [thread overview]
Message-ID: <63d13a47.170a0220.e629f.6974@mx.google.com> (raw)
In-Reply-To: <87a626n64x.fsf@localhost>
Ihor Radchenko <yantar92@posteo.net> writes:
> Tim Cross <theophilusx@gmail.com> writes:
>
>> to be very clear, ob-sql is not adding any NEW interface to any external
>> program. It is just using the Emacs built-in SQL library (Elisp), which
>> has been part of Emacs for a long time (I was using it in late 90s to
>> work with Oracle RDMS). It is this library that provides the 'support'
>> for things like Oracle's RDMS. If you want more specific information,
>> ask on emacs-devel. Org mode is just using this built-in library.
>
> This is wrong.
> `org-babel-execute:sql' directly calls the CLI executable via `process-file'.
>
> That said, the discussion about sql.el is also relevant wrt non-free SQL
> client support. It will be helpful to clarify what is morally acceptable
> for all the scenarios, not just for Org's use-case.
>
>> The Oracle database is simply a relational database management system in
>> the same way as Postgres, MySQL, Ingris, MS-Sql server etc. All of these
>> have a CLI client and support connections via JDBC. The sql.el library
>> provides specialised comint based interfaces which run the CLI to
>> communicate with the RDMS. The closest of your 3 choices is b, as the
>> build-in Emacs sql library executes the RDMS CLI in a sub-process comint
>> buffer.
>
> Org does not use this comint interface yet. We may in future though, for
> sessions:
>
> (defun org-babel-prep-session:sql (_session _params)
> "Raise an error because Sql sessions aren't implemented."
> (error "SQL sessions not yet implemented"))
OK, thanks the for correction. I was confused because the set of
supported RDBMS is the same as those supported by sql.el and the
connection credentials uses the same variable name
i.e. sql-connection-alist.
However, I gues the point remains, sql.el and ob-sql.el support a number
of non-free RDMS and I think this is fine given that
1. There is no encouragement, implicit or explicit, to use a non-free
database
2. Provided support provides a way to interact with these non-free RDMS using
free software.
3. There is no requirement to install non-free software to use
ob-sql.el. The software is fully functional using a free RDMS like
postgres.
For maintenance reasons and to add session support, I would suggest that
using sql.el instead of re-inventing this wheel would be a better
outcome. I've used sql.el for years and it works extremely well and I
don't htink it would be too hard to integrate into ob-sql.
next prev parent reply other threads:[~2023-01-25 14:20 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 10:48 [PATCH] ob-sql: Add support for Athena Daniel Kraus
2023-01-16 11:13 ` Ihor Radchenko
2023-01-16 11:52 ` Daniel Kraus
2023-01-16 20:50 ` Tim Cross
2023-01-17 9:42 ` Daniel Kraus
2023-01-17 10:06 ` Supporting non-free SQL clients in ob-sql (was: [PATCH] ob-sql: Add support for Athena) Ihor Radchenko
2023-01-17 11:38 ` Tim Cross
2023-01-23 4:23 ` Richard Stallman
2023-01-23 6:33 ` Jean Louis
2023-01-25 4:31 ` Richard Stallman
2023-01-25 7:57 ` Tim Cross
2023-01-25 12:35 ` Ihor Radchenko
2023-01-25 14:05 ` Tim Cross [this message]
2023-01-25 14:31 ` Ihor Radchenko
2023-01-25 21:11 ` Tim Cross
2023-02-26 2:59 ` Richard Stallman
2023-01-28 4:45 ` Richard Stallman
2023-01-30 14:51 ` Ihor Radchenko
2023-01-28 4:43 ` Richard Stallman
2023-01-25 11:51 ` Jean Louis
2023-01-29 5:15 ` Richard Stallman
2023-01-23 12:45 ` Ihor Radchenko
2023-01-23 20:12 ` Tim Cross
2023-01-26 4:25 ` Richard Stallman
2023-01-26 6:59 ` Supporting non-free SQL clients in ob-sql Loris Bennett
2023-01-26 10:22 ` Supporting non-free SQL clients in ob-sql (was: [PATCH] ob-sql: Add support for Athena) Ihor Radchenko
2023-01-26 11:05 ` Supporting non-free SQL clients in ob-sql Heinz Tuechler
2023-01-26 11:14 ` Ihor Radchenko
2023-01-26 11:47 ` Heinz Tuechler
2023-01-28 4:45 ` Supporting non-free SQL clients in ob-sql (was: [PATCH] ob-sql: Add support for Athena) Richard Stallman
2023-01-29 14:21 ` Ihor Radchenko
2023-02-04 5:15 ` Richard Stallman
2023-01-26 4:26 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63d13a47.170a0220.e629f.6974@mx.google.com \
--to=theophilusx@gmail.com \
--cc=bugs@gnu.support \
--cc=emacs-orgmode@gnu.org \
--cc=rms@gnu.org \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).