From: Daniel Kraus <daniel@kraus.my>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] ob-sql: Add support for Athena
Date: Mon, 16 Jan 2023 12:52:40 +0100 [thread overview]
Message-ID: <87zgaiadpx.fsf@kraus.my> (raw)
In-Reply-To: <87358an35i.fsf@localhost>
Ihor Radchenko <yantar92@posteo.net> writes:
> Daniel Kraus <daniel@kraus.my> writes:
>
>> I'm using this patch since a few month that adds support
>> for AWS Athena.
>> The only thing that's maybe against adding it is that
>> `athenacli` (https://github.com/dbcli/athenacli) is not an
>> official AWS tool but just a Python script.
>>
>> What's the opinion on this?
>
> Is this something commonly used?
Athena itself is very widely used. But everyone uses either the
AWS Webinterface or connect with JDBC (DBeaver/Datagrip etc) to it.
The Python tool doesn't seem so popular (only 200 GitHub stars),
that's also my main reason for not adding it.
> I see two main issues with the idea:
> 1. I do not like the idea of adding all the possible CLI tools over
> there in ad-hoc manner. It would be cleaner to provide a
> customization to add various cli tools in a defcustom/defvar without
> manually changing the functions.
>
> 2. I feel like it will be hard to maintain such unpopular clients. If
> (1) is addressed + good automatic tests are implemented, things may
> be acceptable for inclusion though.
>
> In summary, I am not against the idea of including a new sql cli, but we
> should better provide a centralized API to do so and make sure that we
> have test coverage, making sure that things are not broken in future,
> when the original committer is gone and nobody else is left familiar
> with specific obscure SQL client.
Completely agree.
If I look in `org-babel-execute:sql` `command`
( https://git.savannah.gnu.org/cgit/emacs/org-mode.git/tree/lisp/ob-sql.el#n256 )
I think it would make sense to somehow make all those commands
customizeable and let users add their own commands.
But that's obviously a bit more work. I'll see if I find time for it
in the coming months.
Thanks,
Daniel
next prev parent reply other threads:[~2023-01-16 12:04 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 10:48 [PATCH] ob-sql: Add support for Athena Daniel Kraus
2023-01-16 11:13 ` Ihor Radchenko
2023-01-16 11:52 ` Daniel Kraus [this message]
2023-01-16 20:50 ` Tim Cross
2023-01-17 9:42 ` Daniel Kraus
2023-01-17 10:06 ` Supporting non-free SQL clients in ob-sql (was: [PATCH] ob-sql: Add support for Athena) Ihor Radchenko
2023-01-17 11:38 ` Tim Cross
2023-01-23 4:23 ` Richard Stallman
2023-01-23 6:33 ` Jean Louis
2023-01-25 4:31 ` Richard Stallman
2023-01-25 7:57 ` Tim Cross
2023-01-25 12:35 ` Ihor Radchenko
2023-01-25 14:05 ` Tim Cross
2023-01-25 14:31 ` Ihor Radchenko
2023-01-25 21:11 ` Tim Cross
2023-02-26 2:59 ` Richard Stallman
2023-01-28 4:45 ` Richard Stallman
2023-01-30 14:51 ` Ihor Radchenko
2023-01-28 4:43 ` Richard Stallman
2023-01-25 11:51 ` Jean Louis
2023-01-29 5:15 ` Richard Stallman
2023-01-23 12:45 ` Ihor Radchenko
2023-01-23 20:12 ` Tim Cross
2023-01-26 4:25 ` Richard Stallman
2023-01-26 6:59 ` Supporting non-free SQL clients in ob-sql Loris Bennett
2023-01-26 10:22 ` Supporting non-free SQL clients in ob-sql (was: [PATCH] ob-sql: Add support for Athena) Ihor Radchenko
2023-01-26 11:05 ` Supporting non-free SQL clients in ob-sql Heinz Tuechler
2023-01-26 11:14 ` Ihor Radchenko
2023-01-26 11:47 ` Heinz Tuechler
2023-01-28 4:45 ` Supporting non-free SQL clients in ob-sql (was: [PATCH] ob-sql: Add support for Athena) Richard Stallman
2023-01-29 14:21 ` Ihor Radchenko
2023-02-04 5:15 ` Richard Stallman
2023-01-26 4:26 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgaiadpx.fsf@kraus.my \
--to=daniel@kraus.my \
--cc=emacs-orgmode@gnu.org \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).