emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: Tim Cross <theophilusx@gmail.com>
Cc: rms@gnu.org, Jean Louis <bugs@gnu.support>, emacs-orgmode@gnu.org
Subject: Re: Supporting non-free SQL clients in ob-sql (was: [PATCH] ob-sql: Add support for Athena)
Date: Wed, 25 Jan 2023 12:35:58 +0000	[thread overview]
Message-ID: <87a626n64x.fsf@localhost> (raw)
In-Reply-To: <63d0e433.170a0220.54a51.4c8f@mx.google.com>

Tim Cross <theophilusx@gmail.com> writes:

> to be very clear, ob-sql is not adding any NEW interface to any external
> program. It is just using the Emacs built-in SQL library (Elisp), which
> has been part of Emacs for a long time (I was using it in late 90s to
> work with Oracle RDMS). It is this library that provides the 'support'
> for things like Oracle's RDMS. If you want more specific information,
> ask on emacs-devel. Org mode is just using this built-in library.

This is wrong.
`org-babel-execute:sql' directly calls the CLI executable via `process-file'.

That said, the discussion about sql.el is also relevant wrt non-free SQL
client support. It will be helpful to clarify what is morally acceptable
for all the scenarios, not just for Org's use-case.

> The Oracle database is simply a relational database management system in
> the same way as Postgres, MySQL, Ingris, MS-Sql server etc. All of these
> have a CLI client and support connections via JDBC. The sql.el library
> provides specialised comint based interfaces which run the CLI to
> communicate with the RDMS. The closest of your 3 choices is b, as the
> build-in Emacs sql library executes the RDMS CLI in a sub-process comint
> buffer.

Org does not use this comint interface yet. We may in future though, for
sessions:

(defun org-babel-prep-session:sql (_session _params)
  "Raise an error because Sql sessions aren't implemented."
  (error "SQL sessions not yet implemented"))

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


  reply	other threads:[~2023-01-25 12:36 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-16 10:48 [PATCH] ob-sql: Add support for Athena Daniel Kraus
2023-01-16 11:13 ` Ihor Radchenko
2023-01-16 11:52   ` Daniel Kraus
2023-01-16 20:50   ` Tim Cross
2023-01-17  9:42     ` Daniel Kraus
2023-01-17 10:06       ` Supporting non-free SQL clients in ob-sql (was: [PATCH] ob-sql: Add support for Athena) Ihor Radchenko
2023-01-17 11:38         ` Tim Cross
2023-01-23  4:23         ` Richard Stallman
2023-01-23  6:33           ` Jean Louis
2023-01-25  4:31             ` Richard Stallman
2023-01-25  7:57               ` Tim Cross
2023-01-25 12:35                 ` Ihor Radchenko [this message]
2023-01-25 14:05                   ` Tim Cross
2023-01-25 14:31                     ` Ihor Radchenko
2023-01-25 21:11                       ` Tim Cross
2023-02-26  2:59                       ` Richard Stallman
2023-01-28  4:45                     ` Richard Stallman
2023-01-30 14:51                       ` Ihor Radchenko
2023-01-28  4:43                 ` Richard Stallman
2023-01-25 11:51               ` Jean Louis
2023-01-29  5:15                 ` Richard Stallman
2023-01-23 12:45           ` Ihor Radchenko
2023-01-23 20:12             ` Tim Cross
2023-01-26  4:25               ` Richard Stallman
2023-01-26  6:59                 ` Supporting non-free SQL clients in ob-sql Loris Bennett
2023-01-26 10:22                 ` Supporting non-free SQL clients in ob-sql (was: [PATCH] ob-sql: Add support for Athena) Ihor Radchenko
2023-01-26 11:05                   ` Supporting non-free SQL clients in ob-sql Heinz Tuechler
2023-01-26 11:14                     ` Ihor Radchenko
2023-01-26 11:47                       ` Heinz Tuechler
2023-01-28  4:45                   ` Supporting non-free SQL clients in ob-sql (was: [PATCH] ob-sql: Add support for Athena) Richard Stallman
2023-01-29 14:21                     ` Ihor Radchenko
2023-02-04  5:15                       ` Richard Stallman
2023-01-26  4:26             ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a626n64x.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=bugs@gnu.support \
    --cc=emacs-orgmode@gnu.org \
    --cc=rms@gnu.org \
    --cc=theophilusx@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).