Possible bug in parsing / clarification of syntax

Possible bug in parsing / clarification of syntax

[Simon Thum]

Hi all,

I have found some irritating behaviour, potentially a bug. I have a 
block agenda which goes like:

tags-todo "@home&TODO=\"TODO\"

and it displays a certain org line that reads

**** TODO_ state triggers

Which is just a heading for dealing with TODO state triggers, and I 
appended the _ as I don't want it to be a TODO.

For example, the global TODO list and syntax highlighting does not 
consider it a todo, but C-c a m TODO="TODO" does. TODO="T" does not, so 
it's not very grave.

Most likely, it's simply an inconsistency arising from not having a real 
parser. I just wanted to report it here so it may get fixed.

Cheers,

Simon

Re: Possible bug in parsing / clarification of syntax

[David Maus]

[-- Attachment #1: Type: text/plain, Size: 928 bytes --]

Hi Simon,

At Sun, 04 Mar 2012 22:30:31 +0100,
Simon Thum wrote:
>
> Hi all,
>
> I have found some irritating behaviour, potentially a bug. I have a
> block agenda which goes like:
>
> tags-todo "@home&TODO=\"TODO\"
>
> and it displays a certain org line that reads
>
> **** TODO_ state triggers
>
> Which is just a heading for dealing with TODO state triggers, and I
> appended the _ as I don't want it to be a TODO.
>
> For example, the global TODO list and syntax highlighting does not
> consider it a todo, but C-c a m TODO="TODO" does. TODO="T" does not,
> so it's not very grave.
>
> Most likely, it's simply an inconsistency arising from not having a
> real parser. I just wanted to report it here so it may get fixed.

Thanks for the report. It was indeed a glitch and it should be fixed
by now in current master.

Best,
  -- David
--
OpenPGP... 0x99ADB83B5A4478E6
Jabber.... dmjena@jabber.org
Email..... dmaus@ictsoc.de

[-- Attachment #2: OpenPGP Digital Signature --]
[-- Type: application/pgp-signature, Size: 230 bytes --]

Re: Possible bug in parsing / clarification of syntax

[Bastien]

[-- Attachment #1: Type: text/plain, Size: 585 bytes --]

Hi Simon,

Simon Thum <simon.thum@gmx.de> writes:

> I have found some irritating behaviour, potentially a bug. I have a block
> agenda which goes like:
>
> tags-todo "@home&TODO=\"TODO\"
>
> and it displays a certain org line that reads
>
> **** TODO_ state triggers

Can you try the following patch (against latest hotfix HEAD) and report? 

Charles, can you let me know if this breaks anything in your usage of
`org-map-entries'? 

David's original fix want to the right direction, except that we also
want to match "* TODO" as a headline. 

Thanks for testing this quite heavily.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: fix-mismatched-todo-entries.patch --]
[-- Type: text/x-patch, Size: 512 bytes --]

diff --git a/lisp/org.el b/lisp/org.el
index 3dd8f88..ea5ef7c 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -12824,7 +12824,7 @@ headlines matching this string."
 		     " *\\(\\<\\("
 		     (mapconcat 'regexp-quote org-todo-keywords-1 "\\|")
 		     (org-re
-		      "\\>\\)\\)? *\\(.*?\\)\\(:[[:alnum:]_@#%:]+:\\)?[ \t]*$")))
+		      "\\>\\)\\)?\\([ \t]*\\|$\\)+\\(.*?\\)\\(:[[:alnum:]_@#%:]+:\\)?[ \t]*$")))
 	 (props (list 'face 'default
 		      'done-face 'org-agenda-done
 		      'undone-face 'default

[-- Attachment #3: Type: text/plain, Size: 14 bytes --]


-- 
 Bastien

Re: Possible bug in parsing / clarification of syntax

[Simon Thum]

Hi Bastien,

my agenda is fine with the patch.

Cheers,

Simon

On 04/10/2012 07:31 PM, Bastien wrote:
> Hi Simon,
>
> Simon Thum<simon.thum@gmx.de>  writes:
>
>> I have found some irritating behaviour, potentially a bug. I have a block
>> agenda which goes like:
>>
>> tags-todo "@home&TODO=\"TODO\"
>>
>> and it displays a certain org line that reads
>>
>> **** TODO_ state triggers
>
> Can you try the following patch (against latest hotfix HEAD) and report?
>
> Charles, can you let me know if this breaks anything in your usage of
> `org-map-entries'?
>
> David's original fix want to the right direction, except that we also
> want to match "* TODO" as a headline.
>
> Thanks for testing this quite heavily.
>
>
>
>
>

Re: Possible bug in parsing / clarification of syntax

[Simon Thum]

Hi Bastien,

I have to revoke my earlier statement. The patch does _not_ remove the 
TODO_ line from the agenda. I see no change at all.

Cheers,

Simon

On 04/10/2012 07:31 PM, Bastien wrote:
> Hi Simon,
>
> Simon Thum<simon.thum@gmx.de>  writes:
>
>> I have found some irritating behaviour, potentially a bug. I have a block
>> agenda which goes like:
>>
>> tags-todo "@home&TODO=\"TODO\"
>>
>> and it displays a certain org line that reads
>>
>> **** TODO_ state triggers
>
> Can you try the following patch (against latest hotfix HEAD) and report?
>
> Charles, can you let me know if this breaks anything in your usage of
> `org-map-entries'?
>
> David's original fix want to the right direction, except that we also
> want to match "* TODO" as a headline.
>
> Thanks for testing this quite heavily.
>
>
>
>
>

Re: Possible bug in parsing / clarification of syntax

[Bastien]

Hi Simon,

Simon Thum <simon.thum@gmx.de> writes:

> I have to revoke my earlier statement. The patch does _not_ remove the
> TODO_ line from the agenda. I see no change at all.

This should be fixed now.

Thanks,

-- 
 Bastien

Re: Possible bug in parsing / clarification of syntax

[Simon Thum]

Hi Bastien,

I have not checked master but on maint it still exists. Do you need any 
more details to reproduce?

Cheers,

Simon


On 05/08/2012 02:13 PM, Bastien wrote:
> Hi Simon,
>
> Simon Thum<simon.thum@gmx.de>  writes:
>
>> I have to revoke my earlier statement. The patch does _not_ remove the
>> TODO_ line from the agenda. I see no change at all.
>
> This should be fixed now.
>
> Thanks,
>

Re: Possible bug in parsing / clarification of syntax

[Nick Dokos]

Simon Thum <simon.thum@gmx.de> wrote:

> Hi Bastien,
> 
> I have not checked master but on maint it still exists. Do you need
> any more details to reproduce?
> 

AFAICT, origin/maint is behind origin/master by 512 commits (ymmv depending
on when the last update happened):

$ git log --oneline origin/maint --not origin/master
$ git log --oneline origin/master --not origin/maint | wc -l
512

so I think you'd better check master: main seems way out of date - is it
even used at this point?

Nick

> Cheers,
> 
> Simon
> 
> 
> On 05/08/2012 02:13 PM, Bastien wrote:
> > Hi Simon,
> >
> > Simon Thum<simon.thum@gmx.de>  writes:
> >
> >> I have to revoke my earlier statement. The patch does _not_ remove the
> >> TODO_ line from the agenda. I see no change at all.
> >
> > This should be fixed now.
> >
> > Thanks,
> >
> 
> 

Re: Possible bug in parsing / clarification of syntax

[Bastien]

Hi Simon,

Simon Thum <simon.thum@gmx.de> writes:

> I have not checked master but on maint it still exists. Do you need any
> more details to reproduce?

The fix is on master, not on maint.

Please check the fix is okay for you.

Also, if Charles can check if the fix does break is local use of
`org-map-entries', I'd appreciate this.

If both of you confirm, I'll apply the fix on maint.

Thanks!

-- 
 Bastien

Re: Possible bug in parsing / clarification of syntax

[Bastien]

Hi Nick,

Nick Dokos <nicholas.dokos@hp.com> writes:

> so I think you'd better check master: main seems way out of date - is it
> even used at this point?

Maint is used to keep a version of Org that is sync'ed with the next
stable Emacs version (currently Emacs 24.1).

The Emacs 24.1 branch is in feature freeze, and only major bug fixes
should be sync'ed.  That's why we try to be very conservative wrt what
goes in maint.

-- 
 Bastien

Re: Possible bug in parsing / clarification of syntax

[Nick Dokos]

Bastien <bzg@gnu.org> wrote:

> Hi Nick,
> 
> Nick Dokos <nicholas.dokos@hp.com> writes:
> 
> > so I think you'd better check master: main seems way out of date - is it
> > even used at this point?
> 
> Maint is used to keep a version of Org that is sync'ed with the next
> stable Emacs version (currently Emacs 24.1).
> 
> The Emacs 24.1 branch is in feature freeze, and only major bug fixes
> should be sync'ed.  That's why we try to be very conservative wrt what
> goes in maint.
> 

Ah, OK - I got confused. Thanks for clarifying!

Nick

Re: Possible bug in parsing / clarification of syntax

[Simon Thum]

On 05/13/2012 07:54 PM, Bastien wrote:
> Hi Simon,
>
> Simon Thum<simon.thum@gmx.de>  writes:
>
>> I have not checked master but on maint it still exists. Do you need any
>> more details to reproduce?
>
> The fix is on master, not on maint.
>
> Please check the fix is okay for you.
>
> Also, if Charles can check if the fix does break is local use of
> `org-map-entries', I'd appreciate this.
>
> If both of you confirm, I'll apply the fix on maint.
Confirmed ;)

Thanks a lot & Cheers,

Simon

Re: Possible bug in parsing / clarification of syntax

[Sebold, Charles]

Sorry so far behind; will check today.

Charlie

-----Original Message-----
From: Bastien Guerry [mailto:bastienguerry@googlemail.com] On Behalf Of Bastien
Sent: Sunday, May 13, 2012 12:54 PM
To: Simon Thum
Cc: Sebold, Charles; emacs-orgmode@gnu.org
Subject: Re: Possible bug in parsing / clarification of syntax

Hi Simon,

Simon Thum <simon.thum@gmx.de> writes:

> I have not checked master but on maint it still exists. Do you need any
> more details to reproduce?

The fix is on master, not on maint.

Please check the fix is okay for you.

Also, if Charles can check if the fix does break is local use of
`org-map-entries', I'd appreciate this.

If both of you confirm, I'll apply the fix on maint.

Thanks!

-- 
 Bastien

Re: Possible bug in parsing / clarification of syntax

[Sebold, Charles]

Confirmed, fix in master works for org-map-entries.

Charlie


-----Original Message-----
From: Simon Thum [mailto:simon.thum@gmx.de] 
Sent: Sunday, May 13, 2012 1:49 PM
To: Bastien
Cc: Sebold, Charles; emacs-orgmode@gnu.org
Subject: Re: Possible bug in parsing / clarification of syntax

On 05/13/2012 07:54 PM, Bastien wrote:
> Hi Simon,
>
> Simon Thum<simon.thum@gmx.de>  writes:
>
>> I have not checked master but on maint it still exists. Do you need any
>> more details to reproduce?
>
> The fix is on master, not on maint.
>
> Please check the fix is okay for you.
>
> Also, if Charles can check if the fix does break is local use of
> `org-map-entries', I'd appreciate this.
>
> If both of you confirm, I'll apply the fix on maint.
Confirmed ;)

Thanks a lot & Cheers,

Simon

Re: Possible bug in parsing / clarification of syntax

[Bastien]

Hi Charles,

"Sebold, Charles" <Charles.Sebold@lcms.org> writes:

> Confirmed, fix in master works for org-map-entries.

Thanks for confirming.  The fix is now in maint.

All best,

-- 
 Bastien