* [PATCH] Revert "Jump to selected clock task when starting the clock"
@ 2009-04-21 2:37 Bernt Hansen
2009-04-21 2:37 ` [PATCH] Add NOBLOCKING to org-default-properties Bernt Hansen
2009-04-21 7:45 ` [PATCH] Revert "Jump to selected clock task when starting the clock" Carsten Dominik
0 siblings, 2 replies; 4+ messages in thread
From: Bernt Hansen @ 2009-04-21 2:37 UTC (permalink / raw)
To: emacs-orgmode; +Cc: Bernt Hansen
This reverts commit 61dfa0c67fcb47351f2139160ad7f59d7e742254.
This wasn't such a great idea after all. There is one case where
this is really annoying - if you are in the middle of displaying
an agenda view with lots of filters active and you change what you
are clocking it jumps away you lose the agenda view.
This one case makes hitting a dedicated function key that runs
org-clock-goto more desireable.
---
I should have sat on that original patch for a week longer before posting it :/
When doing my weekly review today I ran into a case where I wanted to change
the clocked task in the middle of reviewing all my outstanding tasks. This jumped
to the task and I lost my place in the middle of my (huge) task list.
This patch is available at git://git.norang.ca/org-mode.git for-carsten
lisp/org-clock.el | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/lisp/org-clock.el b/lisp/org-clock.el
index 21f298d..0d51275 100644
--- a/lisp/org-clock.el
+++ b/lisp/org-clock.el
@@ -380,8 +380,7 @@ the clocking selection, associated with the letter `d'."
(org-clock-update-mode-line)
(setq org-clock-mode-line-timer
(run-with-timer 60 60 'org-clock-update-mode-line))
- (message "Clock started at %s" ts)))))
- (org-clock-goto nil)))
+ (message "Clock started at %s" ts)))))))
(defun org-clock-find-position (find-unclosed)
"Find the location where the next clock line should be inserted.
--
1.6.3.rc1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] Add NOBLOCKING to org-default-properties
2009-04-21 2:37 [PATCH] Revert "Jump to selected clock task when starting the clock" Bernt Hansen
@ 2009-04-21 2:37 ` Bernt Hansen
2009-04-21 7:45 ` Carsten Dominik
2009-04-21 7:45 ` [PATCH] Revert "Jump to selected clock task when starting the clock" Carsten Dominik
1 sibling, 1 reply; 4+ messages in thread
From: Bernt Hansen @ 2009-04-21 2:37 UTC (permalink / raw)
To: emacs-orgmode; +Cc: Bernt Hansen
This allows setting the NOBLOCKING property by hitting C-c C-c on
the :PROPERTIES: drawer
---
This patch is available at git://git.norang.ca/org-mode.git for-carsten
lisp/org.el | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lisp/org.el b/lisp/org.el
index 723ad45..c964adf 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -11152,7 +11152,7 @@ but in some other way.")
"LOCATION" "LOGGING" "COLUMNS" "VISIBILITY"
"TABLE_EXPORT_FORMAT" "TABLE_EXPORT_FILE"
"EXPORT_FILE_NAME" "EXPORT_TITLE" "EXPORT_AUTHOR" "EXPORT_DATE"
- "ORDERED")
+ "ORDERED" "NOBLOCKING")
"Some properties that are used by Org-mode for various purposes.
Being in this list makes sure that they are offered for completion.")
--
1.6.3.rc1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] Add NOBLOCKING to org-default-properties
2009-04-21 2:37 ` [PATCH] Add NOBLOCKING to org-default-properties Bernt Hansen
@ 2009-04-21 7:45 ` Carsten Dominik
0 siblings, 0 replies; 4+ messages in thread
From: Carsten Dominik @ 2009-04-21 7:45 UTC (permalink / raw)
To: Bernt Hansen; +Cc: emacs-orgmode
Applied, thanks.
- Carsten
On Apr 21, 2009, at 4:37 AM, Bernt Hansen wrote:
> This allows setting the NOBLOCKING property by hitting C-c C-c on
> the :PROPERTIES: drawer
> ---
>
> This patch is available at git://git.norang.ca/org-mode.git for-
> carsten
>
> lisp/org.el | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/lisp/org.el b/lisp/org.el
> index 723ad45..c964adf 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -11152,7 +11152,7 @@ but in some other way.")
> "LOCATION" "LOGGING" "COLUMNS" "VISIBILITY"
> "TABLE_EXPORT_FORMAT" "TABLE_EXPORT_FILE"
> "EXPORT_FILE_NAME" "EXPORT_TITLE" "EXPORT_AUTHOR" "EXPORT_DATE"
> - "ORDERED")
> + "ORDERED" "NOBLOCKING")
> "Some properties that are used by Org-mode for various purposes.
> Being in this list makes sure that they are offered for completion.")
>
> --
> 1.6.3.rc1
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Revert "Jump to selected clock task when starting the clock"
2009-04-21 2:37 [PATCH] Revert "Jump to selected clock task when starting the clock" Bernt Hansen
2009-04-21 2:37 ` [PATCH] Add NOBLOCKING to org-default-properties Bernt Hansen
@ 2009-04-21 7:45 ` Carsten Dominik
1 sibling, 0 replies; 4+ messages in thread
From: Carsten Dominik @ 2009-04-21 7:45 UTC (permalink / raw)
To: Bernt Hansen; +Cc: emacs-orgmode
Reverted, thanks.
- Carsten
On Apr 21, 2009, at 4:37 AM, Bernt Hansen wrote:
> This reverts commit 61dfa0c67fcb47351f2139160ad7f59d7e742254.
>
> This wasn't such a great idea after all. There is one case where
> this is really annoying - if you are in the middle of displaying
> an agenda view with lots of filters active and you change what you
> are clocking it jumps away you lose the agenda view.
>
> This one case makes hitting a dedicated function key that runs
> org-clock-goto more desireable.
> ---
> I should have sat on that original patch for a week longer before
> posting it :/
> When doing my weekly review today I ran into a case where I wanted
> to change
> the clocked task in the middle of reviewing all my outstanding
> tasks. This jumped
> to the task and I lost my place in the middle of my (huge) task list.
>
> This patch is available at git://git.norang.ca/org-mode.git for-
> carsten
>
> lisp/org-clock.el | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/lisp/org-clock.el b/lisp/org-clock.el
> index 21f298d..0d51275 100644
> --- a/lisp/org-clock.el
> +++ b/lisp/org-clock.el
> @@ -380,8 +380,7 @@ the clocking selection, associated with the
> letter `d'."
> (org-clock-update-mode-line)
> (setq org-clock-mode-line-timer
> (run-with-timer 60 60 'org-clock-update-mode-line))
> - (message "Clock started at %s" ts)))))
> - (org-clock-goto nil)))
> + (message "Clock started at %s" ts)))))))
>
> (defun org-clock-find-position (find-unclosed)
> "Find the location where the next clock line should be inserted.
> --
> 1.6.3.rc1
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-04-21 8:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-21 2:37 [PATCH] Revert "Jump to selected clock task when starting the clock" Bernt Hansen
2009-04-21 2:37 ` [PATCH] Add NOBLOCKING to org-default-properties Bernt Hansen
2009-04-21 7:45 ` Carsten Dominik
2009-04-21 7:45 ` [PATCH] Revert "Jump to selected clock task when starting the clock" Carsten Dominik
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).