From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bernt Hansen Subject: [PATCH] Revert "Jump to selected clock task when starting the clock" Date: Mon, 20 Apr 2009 22:37:46 -0400 Message-ID: <1240281467-15562-1-git-send-email-bernt@norang.ca> Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lw5s1-0005L0-Fn for emacs-orgmode@gnu.org; Mon, 20 Apr 2009 22:38:01 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lw5rw-0005KU-TB for emacs-orgmode@gnu.org; Mon, 20 Apr 2009 22:38:00 -0400 Received: from [199.232.76.173] (port=44948 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lw5rw-0005KR-Q1 for emacs-orgmode@gnu.org; Mon, 20 Apr 2009 22:37:56 -0400 Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:55681) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Lw5rw-0001Do-7k for emacs-orgmode@gnu.org; Mon, 20 Apr 2009 22:37:56 -0400 Received: from cpe000102d0fe75-cm0012256ecbde.cpe.net.cable.rogers.com ([99.239.148.180] helo=mail.norang.ca) by mho-02-ewr.mailhop.org with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.68) (envelope-from ) id 1Lw5rv-000CQd-9G for emacs-orgmode@gnu.org; Tue, 21 Apr 2009 02:37:55 +0000 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Cc: Bernt Hansen This reverts commit 61dfa0c67fcb47351f2139160ad7f59d7e742254. This wasn't such a great idea after all. There is one case where this is really annoying - if you are in the middle of displaying an agenda view with lots of filters active and you change what you are clocking it jumps away you lose the agenda view. This one case makes hitting a dedicated function key that runs org-clock-goto more desireable. --- I should have sat on that original patch for a week longer before posting it :/ When doing my weekly review today I ran into a case where I wanted to change the clocked task in the middle of reviewing all my outstanding tasks. This jumped to the task and I lost my place in the middle of my (huge) task list. This patch is available at git://git.norang.ca/org-mode.git for-carsten lisp/org-clock.el | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/lisp/org-clock.el b/lisp/org-clock.el index 21f298d..0d51275 100644 --- a/lisp/org-clock.el +++ b/lisp/org-clock.el @@ -380,8 +380,7 @@ the clocking selection, associated with the letter `d'." (org-clock-update-mode-line) (setq org-clock-mode-line-timer (run-with-timer 60 60 'org-clock-update-mode-line)) - (message "Clock started at %s" ts))))) - (org-clock-goto nil))) + (message "Clock started at %s" ts))))))) (defun org-clock-find-position (find-unclosed) "Find the location where the next clock line should be inserted. -- 1.6.3.rc1