From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: [PATCH] Revert "Jump to selected clock task when starting the clock" Date: Tue, 21 Apr 2009 09:45:13 +0200 Message-ID: <41BC4AA2-8D01-4CD1-9134-67AEF389574E@gmail.com> References: <1240281467-15562-1-git-send-email-bernt@norang.ca> Mime-Version: 1.0 (Apple Message framework v930.3) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LwBBU-0003m7-TF for emacs-orgmode@gnu.org; Tue, 21 Apr 2009 04:18:28 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LwBBQ-0003kj-6p for emacs-orgmode@gnu.org; Tue, 21 Apr 2009 04:18:28 -0400 Received: from [199.232.76.173] (port=40102 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LwBBP-0003kb-Th for emacs-orgmode@gnu.org; Tue, 21 Apr 2009 04:18:23 -0400 Received: from mx20.gnu.org ([199.232.41.8]:55701) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LwBBP-0000w5-AZ for emacs-orgmode@gnu.org; Tue, 21 Apr 2009 04:18:23 -0400 Received: from qw-out-1920.google.com ([74.125.92.145]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LwBBO-00065U-QV for emacs-orgmode@gnu.org; Tue, 21 Apr 2009 04:18:22 -0400 Received: by qw-out-1920.google.com with SMTP id 4so1041146qwk.24 for ; Tue, 21 Apr 2009 01:18:22 -0700 (PDT) In-Reply-To: <1240281467-15562-1-git-send-email-bernt@norang.ca> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bernt Hansen Cc: emacs-orgmode@gnu.org Reverted, thanks. - Carsten On Apr 21, 2009, at 4:37 AM, Bernt Hansen wrote: > This reverts commit 61dfa0c67fcb47351f2139160ad7f59d7e742254. > > This wasn't such a great idea after all. There is one case where > this is really annoying - if you are in the middle of displaying > an agenda view with lots of filters active and you change what you > are clocking it jumps away you lose the agenda view. > > This one case makes hitting a dedicated function key that runs > org-clock-goto more desireable. > --- > I should have sat on that original patch for a week longer before > posting it :/ > When doing my weekly review today I ran into a case where I wanted > to change > the clocked task in the middle of reviewing all my outstanding > tasks. This jumped > to the task and I lost my place in the middle of my (huge) task list. > > This patch is available at git://git.norang.ca/org-mode.git for- > carsten > > lisp/org-clock.el | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/lisp/org-clock.el b/lisp/org-clock.el > index 21f298d..0d51275 100644 > --- a/lisp/org-clock.el > +++ b/lisp/org-clock.el > @@ -380,8 +380,7 @@ the clocking selection, associated with the > letter `d'." > (org-clock-update-mode-line) > (setq org-clock-mode-line-timer > (run-with-timer 60 60 'org-clock-update-mode-line)) > - (message "Clock started at %s" ts))))) > - (org-clock-goto nil))) > + (message "Clock started at %s" ts))))))) > > (defun org-clock-find-position (find-unclosed) > "Find the location where the next clock line should be inserted. > -- > 1.6.3.rc1 > > > > _______________________________________________ > Emacs-orgmode mailing list > Remember: use `Reply All' to send replies to the list. > Emacs-orgmode@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-orgmode