[PATCH] Trivial fix for "%3f" in URL bug

[PATCH] Trivial fix for "%3f" in URL bug

[Ivan Vilata i Balaguer]

[-- Attachment #1.1.1: Type: text/plain, Size: 598 bytes --]

Hi all,

Regarding the previous thread “"%3f" shouldn't be unescaped in HTTP URLs”, I
suggested that leaving the '?' or '%3f' characters in a URL as provided by the
user might be the best thing to do, since they mean different things (query
separator and literal question mark, respectively) and the user should know
best (especially if the URL was copied from a browser).

Fixing the old behaviour is trivial: just remove the ``(?? . "%3F")`` entry
from the ``org-link-escape-chars`` list in ``org.el``.

Cheers,

::

  Ivan Vilata i Balaguer -- http://ivan.lovesgazpacho.net/

[-- Attachment #1.1.2: org.el.patch --]
[-- Type: text/x-diff, Size: 266 bytes --]

--- org.el.orig	2010-03-17 11:51:04.000000000 +0100
+++ org.el	2010-03-17 11:51:42.000000000 +0100
@@ -7877,7 +7877,6 @@
     (?\371 . "%F9")  ; `u
     (?\373 . "%FB")  ; ^u
     (?\;   . "%3B")
-    (??    . "%3F")
     (?=    . "%3D")
     (?+    . "%2B")
     )

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 316 bytes --]

[-- Attachment #2: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

Re: [PATCH] Trivial fix for "%3f" in URL bug

[Carsten Dominik]

On Mar 17, 2010, at 11:53 AM, Ivan Vilata i Balaguer wrote:

> Hi all,
>
> Regarding the previous thread “"%3f" shouldn't be unescaped in HTTP  
> URLs”, I
> suggested that leaving the '?' or '%3f' characters in a URL as  
> provided by the
> user might be the best thing to do, since they mean different things  
> (query
> separator and literal question mark, respectively) and the user  
> should know
> best (especially if the URL was copied from a browser).
>
> Fixing the old behaviour is trivial: just remove the ``(?? .  
> "%3F")`` entry
> from the ``org-link-escape-chars`` list in ``org.el``.

OK, I have applied this patch, thanks.  I am, however, wondering if this
does the right thing consistently, for example also when adding URLs
containing a question mark using `C-c C-l'.  Or when editing a link
with `C-c C-l' while the cursor is on it.  Maybe you or others can make
a few more tests in this direction?

Thanks.

- Carsten

Re: [PATCH] Trivial fix for "%3f" in URL bug

[Ivan Vilata i Balaguer]

[-- Attachment #1.1: Type: text/plain, Size: 801 bytes --]

Carsten Dominik (2010-03-17 12:04:37 +0100) dixit::

> On Mar 17, 2010, at 11:53 AM, Ivan Vilata i Balaguer wrote:
> 
> >Fixing the old behaviour is trivial: just remove the ``(?? .
> >"%3F")`` entry
> >from the ``org-link-escape-chars`` list in ``org.el``.
> 
> OK, I have applied this patch, thanks.  I am, however, wondering if this
> does the right thing consistently, for example also when adding URLs
> containing a question mark using `C-c C-l'.  Or when editing a link
> with `C-c C-l' while the cursor is on it.  Maybe you or others can make
> a few more tests in this direction?

I've tested those behaviours in the new, fixed release and they all seem to be
ok.  HTML export also works correctly.  Thanks!

::

  Ivan Vilata i Balaguer -- http://ivan.lovesgazpacho.net/

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 316 bytes --]

[-- Attachment #2: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode