From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: [PATCH] Trivial fix for "%3f" in URL bug Date: Wed, 17 Mar 2010 12:04:37 +0100 Message-ID: References: <20100317105350.GA2782@edgar.terramar.selidor.net> Mime-Version: 1.0 (Apple Message framework v936) Content-Type: text/plain; charset=WINDOWS-1252; format=flowed; delsp=yes Content-Transfer-Encoding: quoted-printable Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nrr3L-000854-90 for emacs-orgmode@gnu.org; Wed, 17 Mar 2010 07:04:43 -0400 Received: from [140.186.70.92] (port=49945 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nrr3J-00083T-Qk for emacs-orgmode@gnu.org; Wed, 17 Mar 2010 07:04:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Nrr3I-0002WN-Dm for emacs-orgmode@gnu.org; Wed, 17 Mar 2010 07:04:41 -0400 Received: from mail-ew0-f218.google.com ([209.85.219.218]:49249) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nrr3I-0002WJ-7g for emacs-orgmode@gnu.org; Wed, 17 Mar 2010 07:04:40 -0400 Received: by ewy10 with SMTP id 10so374202ewy.32 for ; Wed, 17 Mar 2010 04:04:39 -0700 (PDT) In-Reply-To: <20100317105350.GA2782@edgar.terramar.selidor.net> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Ivan Vilata i Balaguer Cc: emacs-orgmode@gnu.org On Mar 17, 2010, at 11:53 AM, Ivan Vilata i Balaguer wrote: > Hi all, > > Regarding the previous thread =93"%3f" shouldn't be unescaped in HTTP =20= > URLs=94, I > suggested that leaving the '?' or '%3f' characters in a URL as =20 > provided by the > user might be the best thing to do, since they mean different things =20= > (query > separator and literal question mark, respectively) and the user =20 > should know > best (especially if the URL was copied from a browser). > > Fixing the old behaviour is trivial: just remove the ``(?? . =20 > "%3F")`` entry > from the ``org-link-escape-chars`` list in ``org.el``. OK, I have applied this patch, thanks. I am, however, wondering if this does the right thing consistently, for example also when adding URLs containing a question mark using `C-c C-l'. Or when editing a link with `C-c C-l' while the cursor is on it. Maybe you or others can make a few more tests in this direction? Thanks. - Carsten