* [PATCH] Trivial fix for "%3f" in URL bug
@ 2010-03-17 10:53 Ivan Vilata i Balaguer
2010-03-17 11:04 ` Carsten Dominik
0 siblings, 1 reply; 3+ messages in thread
From: Ivan Vilata i Balaguer @ 2010-03-17 10:53 UTC (permalink / raw)
To: emacs-orgmode
[-- Attachment #1.1.1: Type: text/plain, Size: 598 bytes --]
Hi all,
Regarding the previous thread “"%3f" shouldn't be unescaped in HTTP URLs”, I
suggested that leaving the '?' or '%3f' characters in a URL as provided by the
user might be the best thing to do, since they mean different things (query
separator and literal question mark, respectively) and the user should know
best (especially if the URL was copied from a browser).
Fixing the old behaviour is trivial: just remove the ``(?? . "%3F")`` entry
from the ``org-link-escape-chars`` list in ``org.el``.
Cheers,
::
Ivan Vilata i Balaguer -- http://ivan.lovesgazpacho.net/
[-- Attachment #1.1.2: org.el.patch --]
[-- Type: text/x-diff, Size: 266 bytes --]
--- org.el.orig 2010-03-17 11:51:04.000000000 +0100
+++ org.el 2010-03-17 11:51:42.000000000 +0100
@@ -7877,7 +7877,6 @@
(?\371 . "%F9") ; `u
(?\373 . "%FB") ; ^u
(?\; . "%3B")
- (?? . "%3F")
(?= . "%3D")
(?+ . "%2B")
)
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 316 bytes --]
[-- Attachment #2: Type: text/plain, Size: 201 bytes --]
_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Trivial fix for "%3f" in URL bug
2010-03-17 10:53 [PATCH] Trivial fix for "%3f" in URL bug Ivan Vilata i Balaguer
@ 2010-03-17 11:04 ` Carsten Dominik
2010-04-19 7:34 ` Ivan Vilata i Balaguer
0 siblings, 1 reply; 3+ messages in thread
From: Carsten Dominik @ 2010-03-17 11:04 UTC (permalink / raw)
To: Ivan Vilata i Balaguer; +Cc: emacs-orgmode
On Mar 17, 2010, at 11:53 AM, Ivan Vilata i Balaguer wrote:
> Hi all,
>
> Regarding the previous thread “"%3f" shouldn't be unescaped in HTTP
> URLs”, I
> suggested that leaving the '?' or '%3f' characters in a URL as
> provided by the
> user might be the best thing to do, since they mean different things
> (query
> separator and literal question mark, respectively) and the user
> should know
> best (especially if the URL was copied from a browser).
>
> Fixing the old behaviour is trivial: just remove the ``(?? .
> "%3F")`` entry
> from the ``org-link-escape-chars`` list in ``org.el``.
OK, I have applied this patch, thanks. I am, however, wondering if this
does the right thing consistently, for example also when adding URLs
containing a question mark using `C-c C-l'. Or when editing a link
with `C-c C-l' while the cursor is on it. Maybe you or others can make
a few more tests in this direction?
Thanks.
- Carsten
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Trivial fix for "%3f" in URL bug
2010-03-17 11:04 ` Carsten Dominik
@ 2010-04-19 7:34 ` Ivan Vilata i Balaguer
0 siblings, 0 replies; 3+ messages in thread
From: Ivan Vilata i Balaguer @ 2010-04-19 7:34 UTC (permalink / raw)
To: emacs-orgmode
[-- Attachment #1.1: Type: text/plain, Size: 801 bytes --]
Carsten Dominik (2010-03-17 12:04:37 +0100) dixit::
> On Mar 17, 2010, at 11:53 AM, Ivan Vilata i Balaguer wrote:
>
> >Fixing the old behaviour is trivial: just remove the ``(?? .
> >"%3F")`` entry
> >from the ``org-link-escape-chars`` list in ``org.el``.
>
> OK, I have applied this patch, thanks. I am, however, wondering if this
> does the right thing consistently, for example also when adding URLs
> containing a question mark using `C-c C-l'. Or when editing a link
> with `C-c C-l' while the cursor is on it. Maybe you or others can make
> a few more tests in this direction?
I've tested those behaviours in the new, fixed release and they all seem to be
ok. HTML export also works correctly. Thanks!
::
Ivan Vilata i Balaguer -- http://ivan.lovesgazpacho.net/
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 316 bytes --]
[-- Attachment #2: Type: text/plain, Size: 201 bytes --]
_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-04-19 7:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-03-17 10:53 [PATCH] Trivial fix for "%3f" in URL bug Ivan Vilata i Balaguer
2010-03-17 11:04 ` Carsten Dominik
2010-04-19 7:34 ` Ivan Vilata i Balaguer
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).