emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Carsten Dominik <carsten.dominik@gmail.com>
To: Ivan Vilata i Balaguer <ivan@selidor.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Trivial fix for "%3f" in URL bug
Date: Wed, 17 Mar 2010 12:04:37 +0100	[thread overview]
Message-ID: <E4269012-4DE0-4C8A-A220-681BF9AC1990@gmail.com> (raw)
In-Reply-To: <20100317105350.GA2782@edgar.terramar.selidor.net>


On Mar 17, 2010, at 11:53 AM, Ivan Vilata i Balaguer wrote:

> Hi all,
>
> Regarding the previous thread “"%3f" shouldn't be unescaped in HTTP  
> URLs”, I
> suggested that leaving the '?' or '%3f' characters in a URL as  
> provided by the
> user might be the best thing to do, since they mean different things  
> (query
> separator and literal question mark, respectively) and the user  
> should know
> best (especially if the URL was copied from a browser).
>
> Fixing the old behaviour is trivial: just remove the ``(?? .  
> "%3F")`` entry
> from the ``org-link-escape-chars`` list in ``org.el``.

OK, I have applied this patch, thanks.  I am, however, wondering if this
does the right thing consistently, for example also when adding URLs
containing a question mark using `C-c C-l'.  Or when editing a link
with `C-c C-l' while the cursor is on it.  Maybe you or others can make
a few more tests in this direction?

Thanks.

- Carsten

next prev parent reply	other threads:[~2010-03-17 11:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-17 10:53 [PATCH] Trivial fix for "%3f" in URL bug Ivan Vilata i Balaguer
2010-03-17 11:04 ` Carsten Dominik [this message]
2010-04-19  7:34   ` Ivan Vilata i Balaguer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E4269012-4DE0-4C8A-A220-681BF9AC1990@gmail.com \
    --to=carsten.dominik@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=ivan@selidor.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).