* [PATCH] icalendar: Make alarm duration RFC5545 compliant
@ 2011-05-12 8:30 Michal Sojka
2011-05-13 12:42 ` [Accepted] " Carsten Dominik
0 siblings, 1 reply; 7+ messages in thread
From: Michal Sojka @ 2011-05-12 8:30 UTC (permalink / raw)
To: Eric S Fraga, emacs-orgmode; +Cc: Michal Sojka
The format of alarm trigger was incorrect because "T" letter from
dur-time element was missing (see
http://tools.ietf.org/html/rfc5545#section-3.3.6). This caused some
software (such as KOrganizer) to not interpret the alarms correctly.
---
lisp/org-icalendar.el | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lisp/org-icalendar.el b/lisp/org-icalendar.el
index c4b1f89..3632b5e 100644
--- a/lisp/org-icalendar.el
+++ b/lisp/org-icalendar.el
@@ -419,7 +419,7 @@ When COMBINE is non nil, add the category to each line."
(let ((t1 (ignore-errors (org-parse-time-string ts 'nodefault))))
(if (and (> org-icalendar-alarm-time 0)
(car t1) (nth 1 t1) (nth 2 t1))
- (setq alarm (format "\nBEGIN:VALARM\nACTION:DISPLAY\nDESCRIPTION:%s\nTRIGGER:-P0D0H%dM0S\nEND:VALARM" summary org-icalendar-alarm-time))
+ (setq alarm (format "\nBEGIN:VALARM\nACTION:DISPLAY\nDESCRIPTION:%s\nTRIGGER:-P0DT0H%dM0S\nEND:VALARM" summary org-icalendar-alarm-time))
(setq alarm ""))
)
(if (string-match org-bracket-link-regexp summary)
--
1.7.2.3
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Accepted] icalendar: Make alarm duration RFC5545 compliant
2011-05-12 8:30 [PATCH] icalendar: Make alarm duration RFC5545 compliant Michal Sojka
@ 2011-05-13 12:42 ` Carsten Dominik
2011-08-24 7:53 ` Michal Sojka
0 siblings, 1 reply; 7+ messages in thread
From: Carsten Dominik @ 2011-05-13 12:42 UTC (permalink / raw)
To: emacs-orgmode
Patch 803 (http://patchwork.newartisans.com/patch/803/) is now "Accepted".
Maintainer comment: none
This relates to the following submission:
http://mid.gmane.org/%3C1305189019-23615-1-git-send-email-sojka%40os.inf.tu-dresden.de%3E
Here is the original message containing the patch:
> Content-Type: text/plain; charset="utf-8"
> MIME-Version: 1.0
> Content-Transfer-Encoding: 7bit
> Subject: [O] icalendar: Make alarm duration RFC5545 compliant
> Date: Thu, 12 May 2011 13:30:19 -0000
> From: Michal Sojka <sojka@os.inf.tu-dresden.de>
> X-Patchwork-Id: 803
> Message-Id: <1305189019-23615-1-git-send-email-sojka@os.inf.tu-dresden.de>
> To: Eric S Fraga <e.fraga@ucl.ac.uk>,
> emacs-orgmode@gnu.org
> Cc: Michal Sojka <sojka@os.inf.tu-dresden.de>
>
> The format of alarm trigger was incorrect because "T" letter from
> dur-time element was missing (see
> http://tools.ietf.org/html/rfc5545#section-3.3.6). This caused some
> software (such as KOrganizer) to not interpret the alarms correctly.
>
> ---
> lisp/org-icalendar.el | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/lisp/org-icalendar.el b/lisp/org-icalendar.el
> index c4b1f89..3632b5e 100644
> --- a/lisp/org-icalendar.el
> +++ b/lisp/org-icalendar.el
> @@ -419,7 +419,7 @@ When COMBINE is non nil, add the category to each line."
> (let ((t1 (ignore-errors (org-parse-time-string ts 'nodefault))))
> (if (and (> org-icalendar-alarm-time 0)
> (car t1) (nth 1 t1) (nth 2 t1))
> - (setq alarm (format "\nBEGIN:VALARM\nACTION:DISPLAY\nDESCRIPTION:%s\nTRIGGER:-P0D0H%dM0S\nEND:VALARM" summary org-icalendar-alarm-time))
> + (setq alarm (format "\nBEGIN:VALARM\nACTION:DISPLAY\nDESCRIPTION:%s\nTRIGGER:-P0DT0H%dM0S\nEND:VALARM" summary org-icalendar-alarm-time))
> (setq alarm ""))
> )
> (if (string-match org-bracket-link-regexp summary)
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Accepted] icalendar: Make alarm duration RFC5545 compliant
2011-05-13 12:42 ` [Accepted] " Carsten Dominik
@ 2011-08-24 7:53 ` Michal Sojka
2011-08-25 13:49 ` Bastien
0 siblings, 1 reply; 7+ messages in thread
From: Michal Sojka @ 2011-08-24 7:53 UTC (permalink / raw)
To: Carsten Dominik, emacs-orgmode
Hi,
it seems that the following patch still didn't appear in the official
repo. Shall I resend it with the commit message according to
http://orgmode.org/worg/org-contribute.html#sec-5, especially with
TINYCHANGE?
Thanks,
Michal
On Fri, 13 May 2011, Carsten Dominik wrote:
> Patch 803 (http://patchwork.newartisans.com/patch/803/) is now "Accepted".
>
> Maintainer comment: none
>
> This relates to the following submission:
>
> http://mid.gmane.org/%3C1305189019-23615-1-git-send-email-sojka%40os.inf.tu-dresden.de%3E
>
> Here is the original message containing the patch:
>
> > Content-Type: text/plain; charset="utf-8"
> > MIME-Version: 1.0
> > Content-Transfer-Encoding: 7bit
> > Subject: [O] icalendar: Make alarm duration RFC5545 compliant
> > Date: Thu, 12 May 2011 13:30:19 -0000
> > From: Michal Sojka <sojka@os.inf.tu-dresden.de>
> > X-Patchwork-Id: 803
> > Message-Id: <1305189019-23615-1-git-send-email-sojka@os.inf.tu-dresden.de>
> > To: Eric S Fraga <e.fraga@ucl.ac.uk>,
> > emacs-orgmode@gnu.org
> > Cc: Michal Sojka <sojka@os.inf.tu-dresden.de>
> >
> > The format of alarm trigger was incorrect because "T" letter from
> > dur-time element was missing (see
> > http://tools.ietf.org/html/rfc5545#section-3.3.6). This caused some
> > software (such as KOrganizer) to not interpret the alarms correctly.
> >
> > ---
> > lisp/org-icalendar.el | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/lisp/org-icalendar.el b/lisp/org-icalendar.el
> > index c4b1f89..3632b5e 100644
> > --- a/lisp/org-icalendar.el
> > +++ b/lisp/org-icalendar.el
> > @@ -419,7 +419,7 @@ When COMBINE is non nil, add the category to each line."
> > (let ((t1 (ignore-errors (org-parse-time-string ts 'nodefault))))
> > (if (and (> org-icalendar-alarm-time 0)
> > (car t1) (nth 1 t1) (nth 2 t1))
> > - (setq alarm (format "\nBEGIN:VALARM\nACTION:DISPLAY\nDESCRIPTION:%s\nTRIGGER:-P0D0H%dM0S\nEND:VALARM" summary org-icalendar-alarm-time))
> > + (setq alarm (format "\nBEGIN:VALARM\nACTION:DISPLAY\nDESCRIPTION:%s\nTRIGGER:-P0DT0H%dM0S\nEND:VALARM" summary org-icalendar-alarm-time))
> > (setq alarm ""))
> > )
> > (if (string-match org-bracket-link-regexp summary)
> >
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Accepted] icalendar: Make alarm duration RFC5545 compliant
2011-08-24 7:53 ` Michal Sojka
@ 2011-08-25 13:49 ` Bastien
2011-08-25 14:34 ` [PATCH] " Michal Sojka
0 siblings, 1 reply; 7+ messages in thread
From: Bastien @ 2011-08-25 13:49 UTC (permalink / raw)
To: Michal Sojka; +Cc: Carsten Dominik, emacs-orgmode
Hi Michal,
Michal Sojka <sojka@os.inf.tu-dresden.de> writes:
> Shall I resend it with the commit message according to
> http://orgmode.org/worg/org-contribute.html#sec-5, especially with
> TINYCHANGE?
Yes, please do. Take care of the following:
- use git format-patch if possible
- create a ChangeLog entry with `C-x 4 a'
- start sentences with an upper-case letter
- add "." at the end of the sentences
- use two whitespaces at the end of sentences
- put variable and function names within `...'
- add TINYCHANGE
Thanks!
--
Bastien, un-procrastinating nitpicking :)
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] icalendar: Make alarm duration RFC5545 compliant
2011-08-25 13:49 ` Bastien
@ 2011-08-25 14:34 ` Michal Sojka
2011-08-25 14:40 ` [Accepted] " Bastien Guerry
2011-08-25 14:40 ` [PATCH] " Bastien
0 siblings, 2 replies; 7+ messages in thread
From: Michal Sojka @ 2011-08-25 14:34 UTC (permalink / raw)
To: bzg; +Cc: Michal Sojka, cdominik, emacs-orgmode
* org-icalendar.el (org-print-icalendar-entries): Make alarm duration
RFC5545 compliant.
The format of alarm trigger was incorrect because "T" letter from
dur-time element was missing (see
http://tools.ietf.org/html/rfc5545#section-3.3.6). This caused some
software (such as KOrganizer) to not interpret the alarms correctly.
TINYCHANGE
---
lisp/org-icalendar.el | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lisp/org-icalendar.el b/lisp/org-icalendar.el
index bc0efce..a3ea88e 100644
--- a/lisp/org-icalendar.el
+++ b/lisp/org-icalendar.el
@@ -419,7 +419,7 @@ When COMBINE is non nil, add the category to each line."
(let ((t1 (ignore-errors (org-parse-time-string ts 'nodefault))))
(if (and (> org-icalendar-alarm-time 0)
(car t1) (nth 1 t1) (nth 2 t1))
- (setq alarm (format "\nBEGIN:VALARM\nACTION:DISPLAY\nDESCRIPTION:%s\nTRIGGER:-P0D0H%dM0S\nEND:VALARM" summary org-icalendar-alarm-time))
+ (setq alarm (format "\nBEGIN:VALARM\nACTION:DISPLAY\nDESCRIPTION:%s\nTRIGGER:-P0DT0H%dM0S\nEND:VALARM" summary org-icalendar-alarm-time))
(setq alarm ""))
)
(if (string-match org-bracket-link-regexp summary)
--
1.7.5.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Accepted] icalendar: Make alarm duration RFC5545 compliant
2011-08-25 14:34 ` [PATCH] " Michal Sojka
@ 2011-08-25 14:40 ` Bastien Guerry
2011-08-25 14:40 ` [PATCH] " Bastien
1 sibling, 0 replies; 7+ messages in thread
From: Bastien Guerry @ 2011-08-25 14:40 UTC (permalink / raw)
To: emacs-orgmode
Patch 913 (http://patchwork.newartisans.com/patch/913/) is now "Accepted".
Maintainer comment: none
This relates to the following submission:
http://mid.gmane.org/%3C1314282867-11165-1-git-send-email-sojka%40os.inf.tu-dresden.de%3E
Here is the original message containing the patch:
> Content-Type: text/plain; charset="utf-8"
> MIME-Version: 1.0
> Content-Transfer-Encoding: 7bit
> Subject: [O] icalendar: Make alarm duration RFC5545 compliant
> Date: Thu, 25 Aug 2011 19:34:27 -0000
> From: Michal Sojka <sojka@os.inf.tu-dresden.de>
> X-Patchwork-Id: 913
> Message-Id: <1314282867-11165-1-git-send-email-sojka@os.inf.tu-dresden.de>
> To: bzg@altern.org
> Cc: Michal Sojka <sojka@os.inf.tu-dresden.de>, cdominik@newartisans.com,
> emacs-orgmode@gnu.org
>
> * org-icalendar.el (org-print-icalendar-entries): Make alarm duration
> RFC5545 compliant.
>
> The format of alarm trigger was incorrect because "T" letter from
> dur-time element was missing (see
> http://tools.ietf.org/html/rfc5545#section-3.3.6). This caused some
> software (such as KOrganizer) to not interpret the alarms correctly.
>
> TINYCHANGE
>
> ---
> lisp/org-icalendar.el | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/lisp/org-icalendar.el b/lisp/org-icalendar.el
> index bc0efce..a3ea88e 100644
> --- a/lisp/org-icalendar.el
> +++ b/lisp/org-icalendar.el
> @@ -419,7 +419,7 @@ When COMBINE is non nil, add the category to each line."
> (let ((t1 (ignore-errors (org-parse-time-string ts 'nodefault))))
> (if (and (> org-icalendar-alarm-time 0)
> (car t1) (nth 1 t1) (nth 2 t1))
> - (setq alarm (format "\nBEGIN:VALARM\nACTION:DISPLAY\nDESCRIPTION:%s\nTRIGGER:-P0D0H%dM0S\nEND:VALARM" summary org-icalendar-alarm-time))
> + (setq alarm (format "\nBEGIN:VALARM\nACTION:DISPLAY\nDESCRIPTION:%s\nTRIGGER:-P0DT0H%dM0S\nEND:VALARM" summary org-icalendar-alarm-time))
> (setq alarm ""))
> )
> (if (string-match org-bracket-link-regexp summary)
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] icalendar: Make alarm duration RFC5545 compliant
2011-08-25 14:34 ` [PATCH] " Michal Sojka
2011-08-25 14:40 ` [Accepted] " Bastien Guerry
@ 2011-08-25 14:40 ` Bastien
1 sibling, 0 replies; 7+ messages in thread
From: Bastien @ 2011-08-25 14:40 UTC (permalink / raw)
To: Michal Sojka; +Cc: cdominik, emacs-orgmode
Michal Sojka <sojka@os.inf.tu-dresden.de> writes:
> * org-icalendar.el (org-print-icalendar-entries): Make alarm duration
> RFC5545 compliant.
Applied -- thanks a lot for making the effort of providing the
ChangeLog!
Best,
--
Bastien
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2011-08-25 14:39 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-12 8:30 [PATCH] icalendar: Make alarm duration RFC5545 compliant Michal Sojka
2011-05-13 12:42 ` [Accepted] " Carsten Dominik
2011-08-24 7:53 ` Michal Sojka
2011-08-25 13:49 ` Bastien
2011-08-25 14:34 ` [PATCH] " Michal Sojka
2011-08-25 14:40 ` [Accepted] " Bastien Guerry
2011-08-25 14:40 ` [PATCH] " Bastien
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).