From: Bastien Guerry <bzg@altern.org>
To: emacs-orgmode@gnu.org
Subject: [Accepted] icalendar: Make alarm duration RFC5545 compliant
Date: Thu, 25 Aug 2011 16:40:06 +0200 (CEST) [thread overview]
Message-ID: <20110825144006.7C0F06023@myhost.localdomain> (raw)
In-Reply-To: 1314282867-11165-1-git-send-email-sojka@os.inf.tu-dresden.de
Patch 913 (http://patchwork.newartisans.com/patch/913/) is now "Accepted".
Maintainer comment: none
This relates to the following submission:
http://mid.gmane.org/%3C1314282867-11165-1-git-send-email-sojka%40os.inf.tu-dresden.de%3E
Here is the original message containing the patch:
> Content-Type: text/plain; charset="utf-8"
> MIME-Version: 1.0
> Content-Transfer-Encoding: 7bit
> Subject: [O] icalendar: Make alarm duration RFC5545 compliant
> Date: Thu, 25 Aug 2011 19:34:27 -0000
> From: Michal Sojka <sojka@os.inf.tu-dresden.de>
> X-Patchwork-Id: 913
> Message-Id: <1314282867-11165-1-git-send-email-sojka@os.inf.tu-dresden.de>
> To: bzg@altern.org
> Cc: Michal Sojka <sojka@os.inf.tu-dresden.de>, cdominik@newartisans.com,
> emacs-orgmode@gnu.org
>
> * org-icalendar.el (org-print-icalendar-entries): Make alarm duration
> RFC5545 compliant.
>
> The format of alarm trigger was incorrect because "T" letter from
> dur-time element was missing (see
> http://tools.ietf.org/html/rfc5545#section-3.3.6). This caused some
> software (such as KOrganizer) to not interpret the alarms correctly.
>
> TINYCHANGE
>
> ---
> lisp/org-icalendar.el | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/lisp/org-icalendar.el b/lisp/org-icalendar.el
> index bc0efce..a3ea88e 100644
> --- a/lisp/org-icalendar.el
> +++ b/lisp/org-icalendar.el
> @@ -419,7 +419,7 @@ When COMBINE is non nil, add the category to each line."
> (let ((t1 (ignore-errors (org-parse-time-string ts 'nodefault))))
> (if (and (> org-icalendar-alarm-time 0)
> (car t1) (nth 1 t1) (nth 2 t1))
> - (setq alarm (format "\nBEGIN:VALARM\nACTION:DISPLAY\nDESCRIPTION:%s\nTRIGGER:-P0D0H%dM0S\nEND:VALARM" summary org-icalendar-alarm-time))
> + (setq alarm (format "\nBEGIN:VALARM\nACTION:DISPLAY\nDESCRIPTION:%s\nTRIGGER:-P0DT0H%dM0S\nEND:VALARM" summary org-icalendar-alarm-time))
> (setq alarm ""))
> )
> (if (string-match org-bracket-link-regexp summary)
>
next prev parent reply other threads:[~2011-08-25 14:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-12 8:30 [PATCH] icalendar: Make alarm duration RFC5545 compliant Michal Sojka
2011-05-13 12:42 ` [Accepted] " Carsten Dominik
2011-08-24 7:53 ` Michal Sojka
2011-08-25 13:49 ` Bastien
2011-08-25 14:34 ` [PATCH] " Michal Sojka
2011-08-25 14:40 ` Bastien Guerry [this message]
2011-08-25 14:40 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110825144006.7C0F06023@myhost.localdomain \
--to=bzg@altern.org \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).