From: Michal Sojka <sojka@os.inf.tu-dresden.de>
To: Eric S Fraga <e.fraga@ucl.ac.uk>, emacs-orgmode@gnu.org
Cc: Michal Sojka <sojka@os.inf.tu-dresden.de>
Subject: [PATCH] icalendar: Make alarm duration RFC5545 compliant
Date: Thu, 12 May 2011 10:30:19 +0200 [thread overview]
Message-ID: <1305189019-23615-1-git-send-email-sojka@os.inf.tu-dresden.de> (raw)
The format of alarm trigger was incorrect because "T" letter from
dur-time element was missing (see
http://tools.ietf.org/html/rfc5545#section-3.3.6). This caused some
software (such as KOrganizer) to not interpret the alarms correctly.
---
lisp/org-icalendar.el | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lisp/org-icalendar.el b/lisp/org-icalendar.el
index c4b1f89..3632b5e 100644
--- a/lisp/org-icalendar.el
+++ b/lisp/org-icalendar.el
@@ -419,7 +419,7 @@ When COMBINE is non nil, add the category to each line."
(let ((t1 (ignore-errors (org-parse-time-string ts 'nodefault))))
(if (and (> org-icalendar-alarm-time 0)
(car t1) (nth 1 t1) (nth 2 t1))
- (setq alarm (format "\nBEGIN:VALARM\nACTION:DISPLAY\nDESCRIPTION:%s\nTRIGGER:-P0D0H%dM0S\nEND:VALARM" summary org-icalendar-alarm-time))
+ (setq alarm (format "\nBEGIN:VALARM\nACTION:DISPLAY\nDESCRIPTION:%s\nTRIGGER:-P0DT0H%dM0S\nEND:VALARM" summary org-icalendar-alarm-time))
(setq alarm ""))
)
(if (string-match org-bracket-link-regexp summary)
--
1.7.2.3
next reply other threads:[~2011-05-12 8:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-12 8:30 Michal Sojka [this message]
2011-05-13 12:42 ` [Accepted] icalendar: Make alarm duration RFC5545 compliant Carsten Dominik
2011-08-24 7:53 ` Michal Sojka
2011-08-25 13:49 ` Bastien
2011-08-25 14:34 ` [PATCH] " Michal Sojka
2011-08-25 14:40 ` [Accepted] " Bastien Guerry
2011-08-25 14:40 ` [PATCH] " Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305189019-23615-1-git-send-email-sojka@os.inf.tu-dresden.de \
--to=sojka@os.inf.tu-dresden.de \
--cc=e.fraga@ucl.ac.uk \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).