emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [PATCH] icalendar: Make alarm duration RFC5545 compliant
@ 2011-05-12  8:30 Michal Sojka
  2011-05-13 12:42 ` [Accepted] " Carsten Dominik
  0 siblings, 1 reply; 7+ messages in thread
From: Michal Sojka @ 2011-05-12  8:30 UTC (permalink / raw)
  To: Eric S Fraga, emacs-orgmode; +Cc: Michal Sojka

The format of alarm trigger was incorrect because "T" letter from
dur-time element was missing (see
http://tools.ietf.org/html/rfc5545#section-3.3.6). This caused some
software (such as KOrganizer) to not interpret the alarms correctly.
---
 lisp/org-icalendar.el |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lisp/org-icalendar.el b/lisp/org-icalendar.el
index c4b1f89..3632b5e 100644
--- a/lisp/org-icalendar.el
+++ b/lisp/org-icalendar.el
@@ -419,7 +419,7 @@ When COMBINE is non nil, add the category to each line."
 	  (let ((t1 (ignore-errors (org-parse-time-string ts 'nodefault))))
 	    (if (and (> org-icalendar-alarm-time 0)
 		     (car t1) (nth 1 t1) (nth 2 t1))
-		(setq alarm (format "\nBEGIN:VALARM\nACTION:DISPLAY\nDESCRIPTION:%s\nTRIGGER:-P0D0H%dM0S\nEND:VALARM" summary org-icalendar-alarm-time))
+		(setq alarm (format "\nBEGIN:VALARM\nACTION:DISPLAY\nDESCRIPTION:%s\nTRIGGER:-P0DT0H%dM0S\nEND:VALARM" summary org-icalendar-alarm-time))
 	      (setq alarm ""))
 	    )
 	  (if (string-match org-bracket-link-regexp summary)
-- 
1.7.2.3

^ permalink raw reply related	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2011-08-25 14:39 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-12  8:30 [PATCH] icalendar: Make alarm duration RFC5545 compliant Michal Sojka
2011-05-13 12:42 ` [Accepted] " Carsten Dominik
2011-08-24  7:53   ` Michal Sojka
2011-08-25 13:49     ` Bastien
2011-08-25 14:34       ` [PATCH] " Michal Sojka
2011-08-25 14:40         ` [Accepted] " Bastien Guerry
2011-08-25 14:40         ` [PATCH] " Bastien

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).