[PATCH] Redisplay agenda with inactive timestamps without prompting the user

[PATCH] Redisplay agenda with inactive timestamps without prompting the user

[Bernt Hansen]

This removes the unnecessary prompt to redisplay the agenda view with
inactive timestamps.  If you hit [ or ] you immediately get the
inactive timestamp view in the daily/weekly agenda view.

You can redisplay without these timestamps by simply hitting 'g'.
---
Hi Carsten,

This patch is available at git://git.norang.ca/org-mode for-carsten

I'm not sure if this prompt I'm removing is really totally useless.  There
are similar prompts for other agenda modes which I haven't tried out yet
with [ and ] so I left those alone.

Regards,
Bernt


 lisp/org-agenda.el |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index fba7014..4f2f41c 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -4957,10 +4957,8 @@ Negative selection means, regexp must not match for selection of an entry."
 (defun org-agenda-manipulate-query (char)
   (cond
    ((memq org-agenda-type '(timeline agenda))
-    (if (y-or-n-p "Re-display with inactive time stamps included? ")
-	(let ((org-agenda-include-inactive-timestamps t))
-	  (org-agenda-redo))
-      (error "Abort")))
+    (let ((org-agenda-include-inactive-timestamps t))
+	  (org-agenda-redo)))
    ((eq org-agenda-type 'search)
     (org-add-to-string
      'org-agenda-query-string
-- 
1.6.4

Re: [PATCH] Redisplay agenda with inactive timestamps without prompting the user

[Carsten Dominik]

Hi Bernt,

the reason for the "prompt" was more documentation, so that
the user knows what is happening.  But I can see that this
get annoying when you know what you are doing.

I have applied you patch, but added a message after it that
explains what the key did.  I guess this is more agreeable?

- Carsten

On Aug 14, 2009, at 8:28 PM, Bernt Hansen wrote:

> This removes the unnecessary prompt to redisplay the agenda view with
> inactive timestamps.  If you hit [ or ] you immediately get the
> inactive timestamp view in the daily/weekly agenda view.
>
> You can redisplay without these timestamps by simply hitting 'g'.
> ---
> Hi Carsten,
>
> This patch is available at git://git.norang.ca/org-mode for-carsten
>
> I'm not sure if this prompt I'm removing is really totally useless.   
> There
> are similar prompts for other agenda modes which I haven't tried out  
> yet
> with [ and ] so I left those alone.
>
> Regards,
> Bernt
>
>
> lisp/org-agenda.el |    6 ++----
> 1 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
> index fba7014..4f2f41c 100644
> --- a/lisp/org-agenda.el
> +++ b/lisp/org-agenda.el
> @@ -4957,10 +4957,8 @@ Negative selection means, regexp must not  
> match for selection of an entry."
> (defun org-agenda-manipulate-query (char)
>   (cond
>    ((memq org-agenda-type '(timeline agenda))
> -    (if (y-or-n-p "Re-display with inactive time stamps included? ")
> -	(let ((org-agenda-include-inactive-timestamps t))
> -	  (org-agenda-redo))
> -      (error "Abort")))
> +    (let ((org-agenda-include-inactive-timestamps t))
> +	  (org-agenda-redo)))
>    ((eq org-agenda-type 'search)
>     (org-add-to-string
>      'org-agenda-query-string
> -- 
> 1.6.4
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

Re: [PATCH] Redisplay agenda with inactive timestamps without prompting the user

[Bernt Hansen]

That's fine -- thanks!

-Bernt

Carsten Dominik <carsten.dominik@gmail.com> writes:

> Hi Bernt,
>
> the reason for the "prompt" was more documentation, so that
> the user knows what is happening.  But I can see that this
> get annoying when you know what you are doing.
>
> I have applied you patch, but added a message after it that
> explains what the key did.  I guess this is more agreeable?
>
> - Carsten
>
> On Aug 14, 2009, at 8:28 PM, Bernt Hansen wrote:
>
>> This removes the unnecessary prompt to redisplay the agenda view with
>> inactive timestamps.  If you hit [ or ] you immediately get the
>> inactive timestamp view in the daily/weekly agenda view.
>>
>> You can redisplay without these timestamps by simply hitting 'g'.
>> ---
>> Hi Carsten,
>>
>> This patch is available at git://git.norang.ca/org-mode for-carsten
>>
>> I'm not sure if this prompt I'm removing is really totally useless.
>> There
>> are similar prompts for other agenda modes which I haven't tried out
>> yet
>> with [ and ] so I left those alone.
>>
>> Regards,
>> Bernt
>>
>>
>> lisp/org-agenda.el |    6 ++----
>> 1 files changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
>> index fba7014..4f2f41c 100644
>> --- a/lisp/org-agenda.el
>> +++ b/lisp/org-agenda.el
>> @@ -4957,10 +4957,8 @@ Negative selection means, regexp must not
>> match for selection of an entry."
>> (defun org-agenda-manipulate-query (char)
>>   (cond
>>    ((memq org-agenda-type '(timeline agenda))
>> -    (if (y-or-n-p "Re-display with inactive time stamps included? ")
>> -	(let ((org-agenda-include-inactive-timestamps t))
>> -	  (org-agenda-redo))
>> -      (error "Abort")))
>> +    (let ((org-agenda-include-inactive-timestamps t))
>> +	  (org-agenda-redo)))
>>    ((eq org-agenda-type 'search)
>>     (org-add-to-string
>>      'org-agenda-query-string
>> -- 
>> 1.6.4
>>
>>
>>
>> _______________________________________________
>> Emacs-orgmode mailing list
>> Remember: use `Reply All' to send replies to the list.
>> Emacs-orgmode@gnu.org
>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode