From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: [PATCH] Redisplay agenda with inactive timestamps without prompting the user Date: Fri, 14 Aug 2009 20:49:40 +0200 Message-ID: <79FD903D-1CA3-4208-A25D-AB858BD7456E@gmail.com> References: <1250274503-12703-1-git-send-email-bernt@norang.ca> Mime-Version: 1.0 (Apple Message framework v936) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mc1qX-0001kc-UG for emacs-orgmode@gnu.org; Fri, 14 Aug 2009 14:49:49 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mc1qT-0001jl-B1 for emacs-orgmode@gnu.org; Fri, 14 Aug 2009 14:49:49 -0400 Received: from [199.232.76.173] (port=35007 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mc1qT-0001jh-3c for emacs-orgmode@gnu.org; Fri, 14 Aug 2009 14:49:45 -0400 Received: from ey-out-1920.google.com ([74.125.78.144]:21771) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mc1qS-00077s-NN for emacs-orgmode@gnu.org; Fri, 14 Aug 2009 14:49:44 -0400 Received: by ey-out-1920.google.com with SMTP id 5so501474eyb.24 for ; Fri, 14 Aug 2009 11:49:43 -0700 (PDT) In-Reply-To: <1250274503-12703-1-git-send-email-bernt@norang.ca> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bernt Hansen Cc: emacs-orgmode@gnu.org Hi Bernt, the reason for the "prompt" was more documentation, so that the user knows what is happening. But I can see that this get annoying when you know what you are doing. I have applied you patch, but added a message after it that explains what the key did. I guess this is more agreeable? - Carsten On Aug 14, 2009, at 8:28 PM, Bernt Hansen wrote: > This removes the unnecessary prompt to redisplay the agenda view with > inactive timestamps. If you hit [ or ] you immediately get the > inactive timestamp view in the daily/weekly agenda view. > > You can redisplay without these timestamps by simply hitting 'g'. > --- > Hi Carsten, > > This patch is available at git://git.norang.ca/org-mode for-carsten > > I'm not sure if this prompt I'm removing is really totally useless. > There > are similar prompts for other agenda modes which I haven't tried out > yet > with [ and ] so I left those alone. > > Regards, > Bernt > > > lisp/org-agenda.el | 6 ++---- > 1 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el > index fba7014..4f2f41c 100644 > --- a/lisp/org-agenda.el > +++ b/lisp/org-agenda.el > @@ -4957,10 +4957,8 @@ Negative selection means, regexp must not > match for selection of an entry." > (defun org-agenda-manipulate-query (char) > (cond > ((memq org-agenda-type '(timeline agenda)) > - (if (y-or-n-p "Re-display with inactive time stamps included? ") > - (let ((org-agenda-include-inactive-timestamps t)) > - (org-agenda-redo)) > - (error "Abort"))) > + (let ((org-agenda-include-inactive-timestamps t)) > + (org-agenda-redo))) > ((eq org-agenda-type 'search) > (org-add-to-string > 'org-agenda-query-string > -- > 1.6.4 > > > > _______________________________________________ > Emacs-orgmode mailing list > Remember: use `Reply All' to send replies to the list. > Emacs-orgmode@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-orgmode