* [PATCH] Redisplay agenda with inactive timestamps without prompting the user
@ 2009-08-14 18:28 Bernt Hansen
2009-08-14 18:49 ` Carsten Dominik
0 siblings, 1 reply; 3+ messages in thread
From: Bernt Hansen @ 2009-08-14 18:28 UTC (permalink / raw)
To: emacs-orgmode; +Cc: Bernt Hansen
This removes the unnecessary prompt to redisplay the agenda view with
inactive timestamps. If you hit [ or ] you immediately get the
inactive timestamp view in the daily/weekly agenda view.
You can redisplay without these timestamps by simply hitting 'g'.
---
Hi Carsten,
This patch is available at git://git.norang.ca/org-mode for-carsten
I'm not sure if this prompt I'm removing is really totally useless. There
are similar prompts for other agenda modes which I haven't tried out yet
with [ and ] so I left those alone.
Regards,
Bernt
lisp/org-agenda.el | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index fba7014..4f2f41c 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -4957,10 +4957,8 @@ Negative selection means, regexp must not match for selection of an entry."
(defun org-agenda-manipulate-query (char)
(cond
((memq org-agenda-type '(timeline agenda))
- (if (y-or-n-p "Re-display with inactive time stamps included? ")
- (let ((org-agenda-include-inactive-timestamps t))
- (org-agenda-redo))
- (error "Abort")))
+ (let ((org-agenda-include-inactive-timestamps t))
+ (org-agenda-redo)))
((eq org-agenda-type 'search)
(org-add-to-string
'org-agenda-query-string
--
1.6.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] Redisplay agenda with inactive timestamps without prompting the user
2009-08-14 18:28 [PATCH] Redisplay agenda with inactive timestamps without prompting the user Bernt Hansen
@ 2009-08-14 18:49 ` Carsten Dominik
2009-08-14 19:22 ` Bernt Hansen
0 siblings, 1 reply; 3+ messages in thread
From: Carsten Dominik @ 2009-08-14 18:49 UTC (permalink / raw)
To: Bernt Hansen; +Cc: emacs-orgmode
Hi Bernt,
the reason for the "prompt" was more documentation, so that
the user knows what is happening. But I can see that this
get annoying when you know what you are doing.
I have applied you patch, but added a message after it that
explains what the key did. I guess this is more agreeable?
- Carsten
On Aug 14, 2009, at 8:28 PM, Bernt Hansen wrote:
> This removes the unnecessary prompt to redisplay the agenda view with
> inactive timestamps. If you hit [ or ] you immediately get the
> inactive timestamp view in the daily/weekly agenda view.
>
> You can redisplay without these timestamps by simply hitting 'g'.
> ---
> Hi Carsten,
>
> This patch is available at git://git.norang.ca/org-mode for-carsten
>
> I'm not sure if this prompt I'm removing is really totally useless.
> There
> are similar prompts for other agenda modes which I haven't tried out
> yet
> with [ and ] so I left those alone.
>
> Regards,
> Bernt
>
>
> lisp/org-agenda.el | 6 ++----
> 1 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
> index fba7014..4f2f41c 100644
> --- a/lisp/org-agenda.el
> +++ b/lisp/org-agenda.el
> @@ -4957,10 +4957,8 @@ Negative selection means, regexp must not
> match for selection of an entry."
> (defun org-agenda-manipulate-query (char)
> (cond
> ((memq org-agenda-type '(timeline agenda))
> - (if (y-or-n-p "Re-display with inactive time stamps included? ")
> - (let ((org-agenda-include-inactive-timestamps t))
> - (org-agenda-redo))
> - (error "Abort")))
> + (let ((org-agenda-include-inactive-timestamps t))
> + (org-agenda-redo)))
> ((eq org-agenda-type 'search)
> (org-add-to-string
> 'org-agenda-query-string
> --
> 1.6.4
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Redisplay agenda with inactive timestamps without prompting the user
2009-08-14 18:49 ` Carsten Dominik
@ 2009-08-14 19:22 ` Bernt Hansen
0 siblings, 0 replies; 3+ messages in thread
From: Bernt Hansen @ 2009-08-14 19:22 UTC (permalink / raw)
To: Carsten Dominik; +Cc: emacs-orgmode
That's fine -- thanks!
-Bernt
Carsten Dominik <carsten.dominik@gmail.com> writes:
> Hi Bernt,
>
> the reason for the "prompt" was more documentation, so that
> the user knows what is happening. But I can see that this
> get annoying when you know what you are doing.
>
> I have applied you patch, but added a message after it that
> explains what the key did. I guess this is more agreeable?
>
> - Carsten
>
> On Aug 14, 2009, at 8:28 PM, Bernt Hansen wrote:
>
>> This removes the unnecessary prompt to redisplay the agenda view with
>> inactive timestamps. If you hit [ or ] you immediately get the
>> inactive timestamp view in the daily/weekly agenda view.
>>
>> You can redisplay without these timestamps by simply hitting 'g'.
>> ---
>> Hi Carsten,
>>
>> This patch is available at git://git.norang.ca/org-mode for-carsten
>>
>> I'm not sure if this prompt I'm removing is really totally useless.
>> There
>> are similar prompts for other agenda modes which I haven't tried out
>> yet
>> with [ and ] so I left those alone.
>>
>> Regards,
>> Bernt
>>
>>
>> lisp/org-agenda.el | 6 ++----
>> 1 files changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
>> index fba7014..4f2f41c 100644
>> --- a/lisp/org-agenda.el
>> +++ b/lisp/org-agenda.el
>> @@ -4957,10 +4957,8 @@ Negative selection means, regexp must not
>> match for selection of an entry."
>> (defun org-agenda-manipulate-query (char)
>> (cond
>> ((memq org-agenda-type '(timeline agenda))
>> - (if (y-or-n-p "Re-display with inactive time stamps included? ")
>> - (let ((org-agenda-include-inactive-timestamps t))
>> - (org-agenda-redo))
>> - (error "Abort")))
>> + (let ((org-agenda-include-inactive-timestamps t))
>> + (org-agenda-redo)))
>> ((eq org-agenda-type 'search)
>> (org-add-to-string
>> 'org-agenda-query-string
>> --
>> 1.6.4
>>
>>
>>
>> _______________________________________________
>> Emacs-orgmode mailing list
>> Remember: use `Reply All' to send replies to the list.
>> Emacs-orgmode@gnu.org
>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-08-14 19:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-08-14 18:28 [PATCH] Redisplay agenda with inactive timestamps without prompting the user Bernt Hansen
2009-08-14 18:49 ` Carsten Dominik
2009-08-14 19:22 ` Bernt Hansen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).