From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bernt Hansen Subject: Re: [PATCH] Redisplay agenda with inactive timestamps without prompting the user Date: Fri, 14 Aug 2009 15:22:14 -0400 Message-ID: <87hbwa6w0p.fsf@gollum.intra.norang.ca> References: <1250274503-12703-1-git-send-email-bernt@norang.ca> <79FD903D-1CA3-4208-A25D-AB858BD7456E@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mc2M4-0004vz-PK for emacs-orgmode@gnu.org; Fri, 14 Aug 2009 15:22:24 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mc2Ly-0004sP-VN for emacs-orgmode@gnu.org; Fri, 14 Aug 2009 15:22:22 -0400 Received: from [199.232.76.173] (port=52636 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mc2Ly-0004s6-HR for emacs-orgmode@gnu.org; Fri, 14 Aug 2009 15:22:18 -0400 Received: from mho-01-ewr.mailhop.org ([204.13.248.71]:59114) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Mc2Ly-0006da-6A for emacs-orgmode@gnu.org; Fri, 14 Aug 2009 15:22:18 -0400 In-Reply-To: <79FD903D-1CA3-4208-A25D-AB858BD7456E@gmail.com> (Carsten Dominik's message of "Fri\, 14 Aug 2009 20\:49\:40 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Carsten Dominik Cc: emacs-orgmode@gnu.org That's fine -- thanks! -Bernt Carsten Dominik writes: > Hi Bernt, > > the reason for the "prompt" was more documentation, so that > the user knows what is happening. But I can see that this > get annoying when you know what you are doing. > > I have applied you patch, but added a message after it that > explains what the key did. I guess this is more agreeable? > > - Carsten > > On Aug 14, 2009, at 8:28 PM, Bernt Hansen wrote: > >> This removes the unnecessary prompt to redisplay the agenda view with >> inactive timestamps. If you hit [ or ] you immediately get the >> inactive timestamp view in the daily/weekly agenda view. >> >> You can redisplay without these timestamps by simply hitting 'g'. >> --- >> Hi Carsten, >> >> This patch is available at git://git.norang.ca/org-mode for-carsten >> >> I'm not sure if this prompt I'm removing is really totally useless. >> There >> are similar prompts for other agenda modes which I haven't tried out >> yet >> with [ and ] so I left those alone. >> >> Regards, >> Bernt >> >> >> lisp/org-agenda.el | 6 ++---- >> 1 files changed, 2 insertions(+), 4 deletions(-) >> >> diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el >> index fba7014..4f2f41c 100644 >> --- a/lisp/org-agenda.el >> +++ b/lisp/org-agenda.el >> @@ -4957,10 +4957,8 @@ Negative selection means, regexp must not >> match for selection of an entry." >> (defun org-agenda-manipulate-query (char) >> (cond >> ((memq org-agenda-type '(timeline agenda)) >> - (if (y-or-n-p "Re-display with inactive time stamps included? ") >> - (let ((org-agenda-include-inactive-timestamps t)) >> - (org-agenda-redo)) >> - (error "Abort"))) >> + (let ((org-agenda-include-inactive-timestamps t)) >> + (org-agenda-redo))) >> ((eq org-agenda-type 'search) >> (org-add-to-string >> 'org-agenda-query-string >> -- >> 1.6.4 >> >> >> >> _______________________________________________ >> Emacs-orgmode mailing list >> Remember: use `Reply All' to send replies to the list. >> Emacs-orgmode@gnu.org >> http://lists.gnu.org/mailman/listinfo/emacs-orgmode