emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nick Dokos <nicholas.dokos@hp.com>
To: Daniel Clemente <n142857@gmail.com>
Cc: nicholas.dokos@hp.com, org-mode Mailinglist <emacs-orgmode@gnu.org>
Subject: Re: custom IDs not exported
Date: Sat, 11 Jun 2011 23:12:26 -0400	[thread overview]
Message-ID: <10721.1307848346@alphaville.dokosmarshall.org> (raw)
In-Reply-To: Message from Daniel Clemente <n142857@gmail.com> of "Sun, 12 Jun 2011 00:42:31 +0200." <87hb7wq9bc.wl%n142857@gmail.com>

Daniel Clemente <n142857@gmail.com> wrote:

> 
>   Commit 438536f6157794101ce0957e39cad6bf70580751 (=E2=80=9EChange undersco=
> res to hyphens in section labels=E2=80=9C) broke the export of CUSTOM_IDs.
> 
>   Take for instance this file:
> 
> -----------------------
> #+TITLE: Cosas por hacer
> 
> * Programas
>   :PROPERTIES:
>   :CUSTOM_ID: programas
>   :END:
> 
> ** emacs
>    :PROPERTIES:
>    :CUSTOM_ID: emacs
>    :END:
> Editor de textos
> 
> ------------------------
> 
> 
>   When exporting (C-c C-e H) you get this table of contents:
> 
> ------------------------
> <div id=3D"text-table-of-contents">
> <ul>
> <li><a href=3D"#programas">1 Programas </a>
> <ul>
> <li><a href=3D"#sec-1_1">1.1 emacs </a></li>
> </ul>
> </li>
> </ul>
> </div>
> 
> -------------------------
> 
>   The first one is correct because it is first-level. All non-first-level g=
> et #sec-NUMBERS instead of the custom ID.
> 
>   Not only the table of contents; the header's ID is also wrong:
> <h3 id=3D"sec-1_1"><a name=3D"sec-1-1" id=3D"sec-1-1"></a><span class=3D"se=
> ction-number-3">1.1</span> emacs </h3>
> 
> 
>   Tested with current org-mode.=20
> 

I was afraid that other exporters might break because of this. Apologies
for the inconvenience. And, btw, thanks for the test case.

I have a minimal patch that I think fixes this problem, but there are
other underscores used in various places in org-html.el so there might
be additional problems. I'd appreciate it if you (and/or others) test it
and report not only on this problem but on any other problems you find.

Thanks,
Nick

diff --git a/lisp/org-html.el b/lisp/org-html.el
index afc6a77..b5d371f 100644
--- a/lisp/org-html.el
+++ b/lisp/org-html.el
@@ -1395,7 +1395,7 @@ lang=\"%s\" xml:lang=\"%s\">
 					   (setq txt (replace-match "" t t txt)))
 					 (setq href
 					       (replace-regexp-in-string
-						"\\." "_" (format "sec-%s" snumber)))
+						"\\." "-" (format "sec-%s" snumber)))
 					 (setq href (org-solidify-link-text (or (cdr (assoc href org-export-preferred-target-alist)) href)))
 					 (push
 					  (format
@@ -2412,7 +2412,7 @@ When TITLE is nil, just close all open levels."
 		(insert "<ul>\n<li>" title "<br/>\n"))))
 	(aset org-levels-open (1- level) t)
 	(setq snumber (org-section-number level)
-	      snu (replace-regexp-in-string "\\." "_" snumber))
+	      snu (replace-regexp-in-string "\\." "-" snumber))
 	(setq level (+ level org-export-html-toplevel-hlevel -1))
 	(if (and num (not body-only))
 	    (setq title (concat

  reply	other threads:[~2011-06-12  3:13 UTC|newest]

Thread overview: 84+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-11 22:42 custom IDs not exported Daniel Clemente
2011-06-12  3:12 ` Nick Dokos [this message]
2011-06-13 10:04   ` Daniel Clemente
2011-06-13 13:16     ` Nick Dokos
2011-06-16 21:31   ` Daniel Clemente
2011-06-16 21:40     ` Nick Dokos
2011-06-16 22:25       ` Daniel Clemente
2011-06-16 22:47         ` Nick Dokos
2011-06-30 16:18           ` Bastien
2011-11-01 17:01   ` Sten Lindner
2011-11-02  5:33     ` Nick Dokos
2011-11-03  1:34       ` Bastien
2011-11-03 14:54         ` Nick Dokos
2011-11-03 17:08           ` Jambunathan K
  -- strict thread matches above, loose matches on Subject: below --
2011-08-22  2:12 Not merging org-lparse, org-xhtml & org-odt to the core Jambunathan K
2011-08-22  7:14 ` Vikas Rawal
2011-08-22  7:48 ` Detlef Steuer
2011-08-22 12:23   ` Sebastien Vauban
2011-08-23 23:46     ` Jambunathan K
2011-08-24  7:44       ` Thomas S. Dye
2011-08-24  8:40         ` Jambunathan K
2011-08-24 16:50           ` Thomas S. Dye
2011-08-24 10:10       ` Bastien
2011-08-24 10:50         ` Jambunathan K
     [not found]           ` <CAN_Dec_=WKB+ZxoP3bwPRexaFQnptV6rha8iQi+O=V61Frj3Zw@mail.gmail.com>
2011-08-25 14:45             ` Jambunathan K
2011-08-26  1:34               ` Matthew Sauer
2011-08-24 10:55       ` Štěpán Němec
2011-08-24 11:23         ` Jambunathan K
2011-08-24 11:38         ` Jambunathan K
2011-08-24 12:04         ` Jambunathan K
     [not found]           ` <87obzesvb7.fsf@gnu.org>
2011-08-25  2:12             ` My apprehensions listed (Re: Not merging org-lparse, org-xhtml & org-odt to the core) Jambunathan K
2011-08-25  2:39               ` Jambunathan K
2011-08-25  7:42                 ` Bastien
2011-08-25  7:21               ` Bastien
     [not found]               ` <kjambunathan@gmail.com>
2011-08-25  5:18                 ` Nick Dokos
2011-10-25  3:33                 ` How to include comments on export? org-exp-blocks.el? Nick Dokos
2011-10-25  4:32                   ` Jambunathan K
2011-10-27 16:28                 ` OT: collage of scripts [was: Re: table alignment failed for Asian characters] Nick Dokos
2011-10-28  6:41                   ` Jambunathan K
2011-10-30 17:48                   ` OT: collage of scripts Thomas S. Dye
2011-11-03 18:18                 ` custom IDs not exported Nick Dokos
2011-11-03 18:40                   ` Jambunathan K
2011-11-04  8:41                   ` Sten Lindner
2011-11-04 15:00                     ` Nick Dokos
2011-11-03 18:44                 ` Nick Dokos
2011-11-04  7:11                   ` [OT] FSF, GPL, cedit case (was: custom IDs not exported) Reiner Steib
2011-08-24 14:48         ` Not merging org-lparse, org-xhtml & org-odt to the core Nick Dokos
2011-08-24 23:26           ` Vikas Rawal
2011-08-24 17:30         ` Allen S. Rout
2011-08-24 18:50           ` Štěpán Němec
2011-08-24 19:30             ` Nick Dokos
2011-08-23 23:24   ` Jambunathan K
2011-08-22 18:09 ` Thomas Renkert
2011-08-23 23:49   ` Jambunathan K
2011-08-24  2:44     ` Vikas Rawal
2011-08-24  6:42       ` Jambunathan K
2011-08-24  7:26         ` Jambunathan K
2011-08-24 10:08           ` Bastien
2011-08-24 10:43             ` Jambunathan K
2011-08-24 10:48             ` Jambunathan K
2011-08-24 13:00             ` Christian Moe
2011-08-24 13:49               ` Stefan Vollmar
2011-08-24 14:10               ` Matt Price
2011-08-24 14:22             ` Rasmus
2011-08-24  9:59         ` Bastien
2011-08-24 10:56           ` Jambunathan K
2011-10-24 21:30 How to include comments on export? org-exp-blocks.el? Herbert Sitz
2011-10-24 22:20 ` Herbert Sitz
2011-10-24 22:52   ` Nick Dokos
2011-10-25  2:43     ` Jambunathan K
2011-10-25  1:57 ` Jambunathan K
2011-10-28 22:31   ` [odt] Support for annotations/comments Jambunathan K
2011-10-29  0:20     ` Herbert Sitz
2011-10-29 10:58     ` Bastien
2011-10-29 14:54     ` Torsten Wagner
2012-01-21  5:53 ` How to include comments on export? org-exp-blocks.el? Samuel Wales
2012-01-23 18:01   ` Eric Schulte
2011-10-27 11:33 table alignment failed for Asian characters Torsten Wagner
2011-10-27 11:55 ` Carsten Dominik
2011-10-27 13:26   ` Torsten Wagner
2011-10-27 13:46     ` Carsten Dominik
2011-10-27 14:00     ` Giovanni Ridolfi
2011-10-27 14:02       ` Carsten Dominik
2011-10-27 14:36         ` Jambunathan K

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10721.1307848346@alphaville.dokosmarshall.org \
    --to=nicholas.dokos@hp.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=n142857@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).