From: Rainer M Krug <Rainer@krugs.de>
To: Marcin Antczak <marcin.antczak@neutrico-themes.pl>
Cc: emacs-orgmode@gnu.org
Subject: Re: [Patch] Few small fixes to html header
Date: Fri, 28 Mar 2014 08:59:07 +0100 [thread overview]
Message-ID: <m2zjkavjn8.fsf@krugs.de> (raw)
In-Reply-To: <87vbuz1kky.fsf@neutrico-themes.pl> (Marcin Antczak's message of "Thu, 27 Mar 2014 20:57:01 +0100")
[-- Attachment #1: Type: text/plain, Size: 1319 bytes --]
Marcin Antczak <marcin.antczak@neutrico-themes.pl> writes:
> I've attached patch below, but I'm affraid that there is something wrong
> with indentation.
> I'm not sure if there is problem with my settings or just entire
> ox-html.el is indented badly.
>
> I've been trying to indent file with the default parameters.
> I started Emacs with -Q parameter and as I can see there is
> a .dir-locals.el in org-mode repo.
>
> So, everything should be ok. Unfortunately there are some differences related to indentation in my patch.
>
> Please review and accept this patch, or enlighten me how to set
> indentation properly.
>
>
> My patch fixes HTML meta data produced on export by ox-html.el
>
> 1. Meta charset definition should be set before title as document title can contain
> some unicode symbols etc.
>
> 2. Added viewport declaration as described here:
>
> https://github.com/h5bp/html5-boilerplate/blob/v4.3.0/doc/html.md
>
> here:
>
> https://developer.apple.com/library/safari/documentation/AppleApplications/Reference/SafariWebContent/UsingtheViewport/UsingtheViewport.html
>
> 3. Fixed unnecessary "\n" at the end of Description meta.
> 4. Removed unnecessary spaces in meta tags.
>
>
>
> Marcin
>
>
--
Rainer M. Krug
email: Rainer<at>krugs<dot>de
PGP: 0x0F52F982
[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 3862 bytes --]
next prev parent reply other threads:[~2014-03-28 7:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-27 19:57 [Patch] Few small fixes to html header Marcin Antczak
2014-03-28 7:59 ` Rainer M Krug [this message]
2014-03-28 10:40 ` Marcin Antczak
2014-03-28 14:43 ` Rick Frankel
2014-03-28 15:16 ` Marcin Antczak
2014-03-28 16:00 ` Rick Frankel
2014-03-28 18:02 ` Marcin Antczak
2014-04-16 14:50 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2zjkavjn8.fsf@krugs.de \
--to=rainer@krugs.de \
--cc=emacs-orgmode@gnu.org \
--cc=marcin.antczak@neutrico-themes.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).