From: Marcin Antczak <marcin.antczak@neutrico-themes.pl>
To: Rick Frankel <rick@rickster.com>
Cc: Bastien <bzg@gnu.org>, emacs-orgmode@gnu.org
Subject: Re: [Patch] Few small fixes to html header
Date: Fri, 28 Mar 2014 19:02:10 +0100 [thread overview]
Message-ID: <87siq2jj6l.fsf@neutrico-themes.pl> (raw)
In-Reply-To: <9c22cfc1384fde6554e716534cb3b9c3@mail.rickster.com>
Rick Frankel writes:
> On 2014-03-28 11:16, Marcin Antczak wrote:
>> Rick Frankel writes:
>>
>> On 2014-03-27 15:57, Marcin Antczak wrote:
>> I've attached patch below, but I'm affraid that there is something
>> wrong
>> with indentation.
>> I'm not sure if there is problem with my settings or just entire
>> ox-html.el is indented badly.
>>
>> Unfortunately, ox-html is indented with a combination of tabs and
>> spaces, you can turn on whitespace-mode to see. I'm not sure why your
>> saving the file has touched areas you didn't edit. Did you do a
>> re-indent or have a whitespace-cleanup or convert-tabs-to-spaces hook
>> turned on?
>>
>> Why ox-html is indented in a way that doesn't follow guidelines
>> described on Emacs Lisp Coding Conventions?
>
> good question. I think because it's actually a very old file.
>
>> Could we fix it?
>
> Another good question. Bastien- Do you think it makes sense to do a
> whitespace cleanup only commit of ox-html to master?
+1 from me.
> That may be, but it's a stylistic issue, not a bug. My read of the
> html dtd does not specify the order of elements in the head. Can you
> show me an example where the order of the elements causes incorrect
> display of the title?
Cannot reproduce this right now.
I had a lot of various problems with Polish Latin-2 ISO-8859-2
characters, but to be honest these were in pre-UTF era.
> Does it cause output which is incorrectly displayed? Otherwise it's
> not really a bug, but i will look at changing it the next time i need
> to touch the file.
There is no output from META tag. So, no.
But, w3c html-markup syntax documentation says:
"end tags consist of the following parts, in exactly the following order:
A "<" character.
A "/" character
The element’s tag name.
Optionally, one or more space characters.
A ">" character.
"
They don't mention any newline character.
>
> I'm worried about touching (4) w/o tests, as sometimes attributes are
> concatenated, and removing a leading whitespace could cause breakage.
It shouldn't.
Meta tag can only have two attributes. There is no reason to concatenate
anything else.
> While source whitespace and output formatting are annoying, our
> approach to modifications of this (quite old) file has been to not
> make changes which don't materially affect functionality or fix bugs
> (the rule of least damage :).
I agree. But code really should be valid and IMHO little improvements
and code cleanups are ok.
Marcin
next prev parent reply other threads:[~2014-03-28 18:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-27 19:57 [Patch] Few small fixes to html header Marcin Antczak
2014-03-28 7:59 ` Rainer M Krug
2014-03-28 10:40 ` Marcin Antczak
2014-03-28 14:43 ` Rick Frankel
2014-03-28 15:16 ` Marcin Antczak
2014-03-28 16:00 ` Rick Frankel
2014-03-28 18:02 ` Marcin Antczak [this message]
2014-04-16 14:50 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87siq2jj6l.fsf@neutrico-themes.pl \
--to=marcin.antczak@neutrico-themes.pl \
--cc=bzg@gnu.org \
--cc=emacs-orgmode@gnu.org \
--cc=rick@rickster.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).