From: Marcin Antczak <marcin.antczak@neutrico-themes.pl>
To: Rick Frankel <rick@rickster.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [Patch] Few small fixes to html header
Date: Fri, 28 Mar 2014 16:16:39 +0100 [thread overview]
Message-ID: <87txaijqug.fsf@neutrico-themes.pl> (raw)
In-Reply-To: <20701b6c1cc0f8eda606e30a052e8e68@mail.rickster.com>
Rick Frankel writes:
> On 2014-03-27 15:57, Marcin Antczak wrote:
>> I've attached patch below, but I'm affraid that there is something
>> wrong
>> with indentation.
>> I'm not sure if there is problem with my settings or just entire
>> ox-html.el is indented badly.
>
> Unfortunately, ox-html is indented with a combination of tabs and
> spaces, you can turn on whitespace-mode to see. I'm not sure why your
> saving the file has touched areas you didn't edit. Did you do a
> re-indent or have a whitespace-cleanup or convert-tabs-to-spaces hook
> turned on?
No. I didn't.
Why ox-html is indented in a way that doesn't follow guidelines
described on Emacs Lisp Coding Conventions?
Could we fix it?
>>
>> My patch fixes HTML meta data produced on export by ox-html.el
>>
>> 1. Meta charset definition should be set before title as document
>> title can contain
>> some unicode symbols etc.
>
> I believe this is the gist of your patch (bug fix?) -- putting the
> content-type declaration before the title (it's hard to tell due to
> all the changes in your patch)? If so, i don't see the need. Following
> is a sample org file w/ a unicode character in the title. It renders
> correctly on both internet explorer 9 and chrome 31.0.1650.63, the
> only browsers i have available right now. I believe that the meta
> content is parsed before the rendering, so the position within the
> header is irrelevant.
>
> #+BEGIN_SRC org
> ,#+TITLE: ☑ \gamma
> ,#+OPTIONS: toc:nil
>
> ,* Test utf-8 title
> Put ☑ \gamma (checkbox and gamma) unicode characters in the title.
> #+END_SRC
But it's still bug.
1. Most modern browsers fallback to UTF-8 currently.
2. Charset is often set by server content type.
So, this is why you can see your example rendered correctly.
But there could be a case where it will not render properly.
From logical point of view - charset should be first. And it's in most
html frameworks such as HTML5 Boilerplate, Twitter Bootstrap etc.
>
>> 2. Added viewport declaration as described here:
>>
>> https://github.com/h5bp/html5-boilerplate/blob/v4.3.0/doc/html.md
>>
>> here:
>>
>> https://developer.apple.com/library/safari/documentation/AppleApplications/Reference/SafariWebContent/UsingtheViewport/UsingtheViewport.html
>
> I don't believe it's appropriate to have as a default in ox-html as
> the current exporter makes no attempt at "responsive design". If you
> would like your exported documents to include it, you can use the
> HTML_HEAD_EXTRA property on a per-file basis, or customize the
> variable `org-html-head-extra'.
Ok.
I'm working on some exporter that outputs HTML with Twitter Bootstrap.
I'll implement this 'viewport' there.
>
>> 3. Fixed unnecessary "\n" at the end of Description meta.
>> 4. Removed unnecessary spaces in meta tags.
>
> Are these bugs or simply stylistic cleanup?
3. This is a bug for me. Meta shouldn't render closing > in new line.
4. Stylistics.
Marcin
next prev parent reply other threads:[~2014-03-28 15:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-27 19:57 [Patch] Few small fixes to html header Marcin Antczak
2014-03-28 7:59 ` Rainer M Krug
2014-03-28 10:40 ` Marcin Antczak
2014-03-28 14:43 ` Rick Frankel
2014-03-28 15:16 ` Marcin Antczak [this message]
2014-03-28 16:00 ` Rick Frankel
2014-03-28 18:02 ` Marcin Antczak
2014-04-16 14:50 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87txaijqug.fsf@neutrico-themes.pl \
--to=marcin.antczak@neutrico-themes.pl \
--cc=emacs-orgmode@gnu.org \
--cc=rick@rickster.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).