* duplicated test names... are these bugs?
@ 2017-09-07 22:30 Stig Brautaset
2017-09-08 11:21 ` Nicolas Goaziou
0 siblings, 1 reply; 2+ messages in thread
From: Stig Brautaset @ 2017-09-07 22:30 UTC (permalink / raw)
To: org mode
Hello!
Running tests on master for me, with make test, results in a single test
failure in `ob-shell/bash-uses-assoc-arrays'. While looking into that I
found that there are _two_ definitions of that in the test-ob-shell.el
file. This strikes me as unlikely to be ideal, and I decided to look a
bit further and it turns out this is not unique. Running the following
command from the top-level org-mode directory
: $ ag --nogroup --nonumbers ert-deftest | sort | uniq -d
Results in
: testing/lisp/test-ob-lilypond.el:(ert-deftest ob-lilypond/ly-gen-html ()
: testing/lisp/test-ob-shell.el:(ert-deftest ob-shell/bash-uses-assoc-arrays ()
: testing/lisp/test-ob-shell.el:(ert-deftest ob-shell/generic-uses-no-assoc-arrays ()
: testing/lisp/test-ob.el:(ert-deftest test-ob/commented-last-block-line-with-var ()
: testing/lisp/test-ob.el:(ert-deftest test-ob/org-babel-remove-result--results-default ()
: testing/lisp/test-ob.el:(ert-deftest test-ob/org-babel-remove-result--results-list ()
: testing/lisp/test-ob.el:(ert-deftest test-ob/org-babel-remove-result--results-pp ()
: testing/lisp/test-org-table.el:(ert-deftest test-org-table/align ()
I'm not super familiar with ert, but I _assume_ that this will lead to
only the last definition of the test with the duplicate names being run
by 'make test'?
Stig
--
; GNU Emacs 26.0.50, Org mode version 9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: duplicated test names... are these bugs?
2017-09-07 22:30 duplicated test names... are these bugs? Stig Brautaset
@ 2017-09-08 11:21 ` Nicolas Goaziou
0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Goaziou @ 2017-09-08 11:21 UTC (permalink / raw)
To: Stig Brautaset; +Cc: org mode
Hello,
Stig Brautaset <stig@brautaset.org> writes:
>
> Running tests on master for me, with make test, results in a single test
> failure in `ob-shell/bash-uses-assoc-arrays'. While looking into that I
> found that there are _two_ definitions of that in the test-ob-shell.el
> file. This strikes me as unlikely to be ideal, and I decided to look a
> bit further and it turns out this is not unique. Running the following
> command from the top-level org-mode directory
>
> : $ ag --nogroup --nonumbers ert-deftest | sort | uniq -d
>
> Results in
>
> : testing/lisp/test-ob-lilypond.el:(ert-deftest ob-lilypond/ly-gen-html ()
> : testing/lisp/test-ob-shell.el:(ert-deftest ob-shell/bash-uses-assoc-arrays ()
> : testing/lisp/test-ob-shell.el:(ert-deftest ob-shell/generic-uses-no-assoc-arrays ()
> : testing/lisp/test-ob.el:(ert-deftest test-ob/commented-last-block-line-with-var ()
> : testing/lisp/test-ob.el:(ert-deftest test-ob/org-babel-remove-result--results-default ()
> : testing/lisp/test-ob.el:(ert-deftest test-ob/org-babel-remove-result--results-list ()
> : testing/lisp/test-ob.el:(ert-deftest test-ob/org-babel-remove-result--results-pp ()
> : testing/lisp/test-org-table.el:(ert-deftest test-org-table/align ()
>
> I'm not super familiar with ert, but I _assume_ that this will lead to
> only the last definition of the test with the duplicate names being run
> by 'make test'?
Fixed. Thank you.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-08 11:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-07 22:30 duplicated test names... are these bugs? Stig Brautaset
2017-09-08 11:21 ` Nicolas Goaziou
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).