From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stig Brautaset Subject: duplicated test names... are these bugs? Date: Thu, 07 Sep 2017 23:30:38 +0100 Message-ID: Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:46957) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dq5Ju-0000co-LR for emacs-orgmode@gnu.org; Thu, 07 Sep 2017 18:30:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dq5Jq-0000N9-39 for emacs-orgmode@gnu.org; Thu, 07 Sep 2017 18:30:46 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:36322) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dq5Jp-0000Kd-SZ for emacs-orgmode@gnu.org; Thu, 07 Sep 2017 18:30:42 -0400 Received: from localhost (host81-131-118-37.range81-131.btcentralplus.com [81.131.118.37]) (Authenticated sender: mailbox@brautaset.org) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id A909AFB87D for ; Fri, 8 Sep 2017 00:30:39 +0200 (CEST) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: org mode Hello! Running tests on master for me, with make test, results in a single test failure in `ob-shell/bash-uses-assoc-arrays'. While looking into that I found that there are _two_ definitions of that in the test-ob-shell.el file. This strikes me as unlikely to be ideal, and I decided to look a bit further and it turns out this is not unique. Running the following command from the top-level org-mode directory : $ ag --nogroup --nonumbers ert-deftest | sort | uniq -d Results in : testing/lisp/test-ob-lilypond.el:(ert-deftest ob-lilypond/ly-gen-html () : testing/lisp/test-ob-shell.el:(ert-deftest ob-shell/bash-uses-assoc-arrays () : testing/lisp/test-ob-shell.el:(ert-deftest ob-shell/generic-uses-no-assoc-arrays () : testing/lisp/test-ob.el:(ert-deftest test-ob/commented-last-block-line-with-var () : testing/lisp/test-ob.el:(ert-deftest test-ob/org-babel-remove-result--results-default () : testing/lisp/test-ob.el:(ert-deftest test-ob/org-babel-remove-result--results-list () : testing/lisp/test-ob.el:(ert-deftest test-ob/org-babel-remove-result--results-pp () : testing/lisp/test-org-table.el:(ert-deftest test-org-table/align () I'm not super familiar with ert, but I _assume_ that this will lead to only the last definition of the test with the duplicate names being run by 'make test'? Stig -- ; GNU Emacs 26.0.50, Org mode version 9.1