From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Stig Brautaset <stig@brautaset.org>
Cc: org mode <emacs-orgmode@gnu.org>
Subject: Re: duplicated test names... are these bugs?
Date: Fri, 08 Sep 2017 13:21:40 +0200 [thread overview]
Message-ID: <877ex9wi4b.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <m2lglqjg4x.fsf@brautaset.org> (Stig Brautaset's message of "Thu, 07 Sep 2017 23:30:38 +0100")
Hello,
Stig Brautaset <stig@brautaset.org> writes:
>
> Running tests on master for me, with make test, results in a single test
> failure in `ob-shell/bash-uses-assoc-arrays'. While looking into that I
> found that there are _two_ definitions of that in the test-ob-shell.el
> file. This strikes me as unlikely to be ideal, and I decided to look a
> bit further and it turns out this is not unique. Running the following
> command from the top-level org-mode directory
>
> : $ ag --nogroup --nonumbers ert-deftest | sort | uniq -d
>
> Results in
>
> : testing/lisp/test-ob-lilypond.el:(ert-deftest ob-lilypond/ly-gen-html ()
> : testing/lisp/test-ob-shell.el:(ert-deftest ob-shell/bash-uses-assoc-arrays ()
> : testing/lisp/test-ob-shell.el:(ert-deftest ob-shell/generic-uses-no-assoc-arrays ()
> : testing/lisp/test-ob.el:(ert-deftest test-ob/commented-last-block-line-with-var ()
> : testing/lisp/test-ob.el:(ert-deftest test-ob/org-babel-remove-result--results-default ()
> : testing/lisp/test-ob.el:(ert-deftest test-ob/org-babel-remove-result--results-list ()
> : testing/lisp/test-ob.el:(ert-deftest test-ob/org-babel-remove-result--results-pp ()
> : testing/lisp/test-org-table.el:(ert-deftest test-org-table/align ()
>
> I'm not super familiar with ert, but I _assume_ that this will lead to
> only the last definition of the test with the duplicate names being run
> by 'make test'?
Fixed. Thank you.
Regards,
--
Nicolas Goaziou
prev parent reply other threads:[~2017-09-08 11:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-07 22:30 duplicated test names... are these bugs? Stig Brautaset
2017-09-08 11:21 ` Nicolas Goaziou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877ex9wi4b.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=stig@brautaset.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).