emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* BUG & [PATCH]: org-clone-subtree-with-time-shift doesn't clean empty property drawers in entire subtree
@ 2010-12-04 17:59 Mike McLean
  2010-12-06  9:03 ` Carsten Dominik
  0 siblings, 1 reply; 2+ messages in thread
From: Mike McLean @ 2010-12-04 17:59 UTC (permalink / raw)
  To: emacs-orgmode

If using org-clone, C-c C-x c, on a subtree instead of a single item,
the loop to call org-remove-empty-drawer-at isn't executing on every
item of the subtree. Changing the re-search-forward seems to do the trick.

Mike



---
 lisp/org.el |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lisp/org.el b/lisp/org.el
index 66514a2..e5a20d3 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -7603,7 +7603,7 @@ and still retain the repeater to cover future
instances of the task."
         (and idprop (if org-clone-delete-id
                 (org-entry-delete nil "ID")
               (org-id-get-create t)))
-        (while (re-search-forward org-property-drawer-re nil t)
+        (while (re-search-forward org-property-start-re nil t)
           (org-remove-empty-drawer-at "PROPERTIES" (point)))
         (goto-char (point-min))
         (when doshift
-- 
1.7.3.2

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: BUG & [PATCH]: org-clone-subtree-with-time-shift doesn't clean empty property drawers in entire subtree
  2010-12-04 17:59 BUG & [PATCH]: org-clone-subtree-with-time-shift doesn't clean empty property drawers in entire subtree Mike McLean
@ 2010-12-06  9:03 ` Carsten Dominik
  0 siblings, 0 replies; 2+ messages in thread
From: Carsten Dominik @ 2010-12-06  9:03 UTC (permalink / raw)
  To: mike.mclean; +Cc: emacs-orgmode

Applied, thanks.

- Carsten

On Dec 4, 2010, at 6:59 PM, Mike McLean wrote:

> If using org-clone, C-c C-x c, on a subtree instead of a single item,
> the loop to call org-remove-empty-drawer-at isn't executing on every
> item of the subtree. Changing the re-search-forward seems to do the  
> trick.
>
> Mike
>
>
>
> ---
> lisp/org.el |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/lisp/org.el b/lisp/org.el
> index 66514a2..e5a20d3 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -7603,7 +7603,7 @@ and still retain the repeater to cover future
> instances of the task."
>         (and idprop (if org-clone-delete-id
>                 (org-entry-delete nil "ID")
>               (org-id-get-create t)))
> -        (while (re-search-forward org-property-drawer-re nil t)
> +        (while (re-search-forward org-property-start-re nil t)
>           (org-remove-empty-drawer-at "PROPERTIES" (point)))
>         (goto-char (point-min))
>         (when doshift
> -- 
> 1.7.3.2
>
>
>
>
>
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

- Carsten

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-12-06  9:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-12-04 17:59 BUG & [PATCH]: org-clone-subtree-with-time-shift doesn't clean empty property drawers in entire subtree Mike McLean
2010-12-06  9:03 ` Carsten Dominik

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).