From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: BUG & [PATCH]: org-clone-subtree-with-time-shift doesn't clean empty property drawers in entire subtree Date: Mon, 6 Dec 2010 10:03:48 +0100 Message-ID: References: <4CFA818F.8070601@pobox.com> Mime-Version: 1.0 (Apple Message framework v936) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from [140.186.70.92] (port=41625 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PPWzD-0004OF-Ol for emacs-orgmode@gnu.org; Mon, 06 Dec 2010 04:03:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PPWzC-000148-JK for emacs-orgmode@gnu.org; Mon, 06 Dec 2010 04:03:55 -0500 Received: from mail-ww0-f49.google.com ([74.125.82.49]:48388) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PPWzC-00013c-F5 for emacs-orgmode@gnu.org; Mon, 06 Dec 2010 04:03:54 -0500 Received: by wwb17 with SMTP id 17so3905197wwb.30 for ; Mon, 06 Dec 2010 01:03:53 -0800 (PST) In-Reply-To: <4CFA818F.8070601@pobox.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: mike.mclean@pobox.com Cc: emacs-orgmode@gnu.org Applied, thanks. - Carsten On Dec 4, 2010, at 6:59 PM, Mike McLean wrote: > If using org-clone, C-c C-x c, on a subtree instead of a single item, > the loop to call org-remove-empty-drawer-at isn't executing on every > item of the subtree. Changing the re-search-forward seems to do the > trick. > > Mike > > > > --- > lisp/org.el | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/lisp/org.el b/lisp/org.el > index 66514a2..e5a20d3 100644 > --- a/lisp/org.el > +++ b/lisp/org.el > @@ -7603,7 +7603,7 @@ and still retain the repeater to cover future > instances of the task." > (and idprop (if org-clone-delete-id > (org-entry-delete nil "ID") > (org-id-get-create t))) > - (while (re-search-forward org-property-drawer-re nil t) > + (while (re-search-forward org-property-start-re nil t) > (org-remove-empty-drawer-at "PROPERTIES" (point))) > (goto-char (point-min)) > (when doshift > -- > 1.7.3.2 > > > > > > > > > _______________________________________________ > Emacs-orgmode mailing list > Please use `Reply All' to send replies to the list. > Emacs-orgmode@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-orgmode - Carsten