emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Carsten Dominik <carsten.dominik@gmail.com>
To: mike.mclean@pobox.com
Cc: emacs-orgmode@gnu.org
Subject: Re: BUG & [PATCH]: org-clone-subtree-with-time-shift doesn't clean empty property drawers in entire subtree
Date: Mon, 6 Dec 2010 10:03:48 +0100	[thread overview]
Message-ID: <FDEDBCF9-69C8-454F-B513-E589F6BFF71D@gmail.com> (raw)
In-Reply-To: <4CFA818F.8070601@pobox.com>

Applied, thanks.

- Carsten

On Dec 4, 2010, at 6:59 PM, Mike McLean wrote:

> If using org-clone, C-c C-x c, on a subtree instead of a single item,
> the loop to call org-remove-empty-drawer-at isn't executing on every
> item of the subtree. Changing the re-search-forward seems to do the  
> trick.
>
> Mike
>
>
>
> ---
> lisp/org.el |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/lisp/org.el b/lisp/org.el
> index 66514a2..e5a20d3 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -7603,7 +7603,7 @@ and still retain the repeater to cover future
> instances of the task."
>         (and idprop (if org-clone-delete-id
>                 (org-entry-delete nil "ID")
>               (org-id-get-create t)))
> -        (while (re-search-forward org-property-drawer-re nil t)
> +        (while (re-search-forward org-property-start-re nil t)
>           (org-remove-empty-drawer-at "PROPERTIES" (point)))
>         (goto-char (point-min))
>         (when doshift
> -- 
> 1.7.3.2
>
>
>
>
>
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

- Carsten

      reply	other threads:[~2010-12-06  9:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-04 17:59 BUG & [PATCH]: org-clone-subtree-with-time-shift doesn't clean empty property drawers in entire subtree Mike McLean
2010-12-06  9:03 ` Carsten Dominik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=FDEDBCF9-69C8-454F-B513-E589F6BFF71D@gmail.com \
    --to=carsten.dominik@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=mike.mclean@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).