* [PATCH] Change timestamps in day-step clocktable from active to inactive
@ 2009-03-05 6:00 Adam Elliott
2009-03-05 15:12 ` Carsten Dominik
0 siblings, 1 reply; 2+ messages in thread
From: Adam Elliott @ 2009-03-05 6:00 UTC (permalink / raw)
To: emacs-orgmode
[-- Attachment #1: Type: text/plain, Size: 496 bytes --]
When run in day-step mode, the clocktable header line for each day's
table contains an active timestamp. I figure it should be an inactive
timestamp, since otherwise I get a junk entry in the agenda each day
(whatever heading was previous to the clocktable).
I'm talking about the output from a spec such as the following:
#+BEGIN: clocktable :block thisweek :step day
Only two lines changed (1079 & 1082 of org-clock.el). Barely worthy of
a formal patch, but I have one attached.
Adam
[-- Attachment #2: org-mode.patch --]
[-- Type: text/plain, Size: 726 bytes --]
--- org-clock.el~ 2009-02-23 08:16:36.000000000 -0500
+++ org-clock.el 2009-03-05 00:35:40.781250000 -0500
@@ -1076,10 +1076,10 @@
(while (< ts te)
(or (bolp) (insert "\n"))
(setq p1 (plist-put p1 :tstart (format-time-string
- (car org-time-stamp-formats)
+ (org-time-stamp-format nil t)
(seconds-to-time ts))))
(setq p1 (plist-put p1 :tend (format-time-string
- (car org-time-stamp-formats)
+ (org-time-stamp-format nil t)
(seconds-to-time (setq ts (+ ts step))))))
(insert "\n" (if (eq step0 'day) "Daily report: " "Weekly report starting on: ")
(plist-get p1 :tstart) "\n")
[-- Attachment #3: Type: text/plain, Size: 204 bytes --]
_______________________________________________
Emacs-orgmode mailing list
Remember: use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Change timestamps in day-step clocktable from active to inactive
2009-03-05 6:00 [PATCH] Change timestamps in day-step clocktable from active to inactive Adam Elliott
@ 2009-03-05 15:12 ` Carsten Dominik
0 siblings, 0 replies; 2+ messages in thread
From: Carsten Dominik @ 2009-03-05 15:12 UTC (permalink / raw)
To: Adam Elliott; +Cc: emacs-orgmode
Applied, thanks.
- Carsten
On Mar 5, 2009, at 7:00 AM, Adam Elliott wrote:
> When run in day-step mode, the clocktable header line for each day's
> table contains an active timestamp. I figure it should be an
> inactive timestamp, since otherwise I get a junk entry in the agenda
> each day (whatever heading was previous to the clocktable).
>
> I'm talking about the output from a spec such as the following:
>
> #+BEGIN: clocktable :block thisweek :step day
>
> Only two lines changed (1079 & 1082 of org-clock.el). Barely worthy
> of a formal patch, but I have one attached.
>
> Adam
> --- org-clock.el~ 2009-02-23 08:16:36.000000000 -0500
> +++ org-clock.el 2009-03-05 00:35:40.781250000 -0500
> @@ -1076,10 +1076,10 @@
> (while (< ts te)
> (or (bolp) (insert "\n"))
> (setq p1 (plist-put p1 :tstart (format-time-string
> - (car org-time-stamp-formats)
> + (org-time-stamp-format nil t)
> (seconds-to-time ts))))
> (setq p1 (plist-put p1 :tend (format-time-string
> - (car org-time-stamp-formats)
> + (org-time-stamp-format nil t)
> (seconds-to-time (setq ts (+ ts step))))))
> (insert "\n" (if (eq step0 'day) "Daily report: " "Weekly
> report starting on: ")
> (plist-get p1 :tstart) "\n")
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-03-05 15:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-03-05 6:00 [PATCH] Change timestamps in day-step clocktable from active to inactive Adam Elliott
2009-03-05 15:12 ` Carsten Dominik
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).