From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: [PATCH] Change timestamps in day-step clocktable from active to inactive Date: Thu, 5 Mar 2009 16:12:16 +0100 Message-ID: References: <49AF6A8E.3030908@hgn.ca> Mime-Version: 1.0 (Apple Message framework v930.3) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LfFFF-0006xn-26 for emacs-orgmode@gnu.org; Thu, 05 Mar 2009 10:12:21 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LfFFD-0006xF-Tg for emacs-orgmode@gnu.org; Thu, 05 Mar 2009 10:12:20 -0500 Received: from [199.232.76.173] (port=35642 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LfFFD-0006x2-O7 for emacs-orgmode@gnu.org; Thu, 05 Mar 2009 10:12:19 -0500 Received: from ey-out-1920.google.com ([74.125.78.146]:51548) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LfFFD-0004dP-6w for emacs-orgmode@gnu.org; Thu, 05 Mar 2009 10:12:19 -0500 Received: by ey-out-1920.google.com with SMTP id 4so616234eyg.24 for ; Thu, 05 Mar 2009 07:12:17 -0800 (PST) In-Reply-To: <49AF6A8E.3030908@hgn.ca> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Adam Elliott Cc: emacs-orgmode@gnu.org Applied, thanks. - Carsten On Mar 5, 2009, at 7:00 AM, Adam Elliott wrote: > When run in day-step mode, the clocktable header line for each day's > table contains an active timestamp. I figure it should be an > inactive timestamp, since otherwise I get a junk entry in the agenda > each day (whatever heading was previous to the clocktable). > > I'm talking about the output from a spec such as the following: > > #+BEGIN: clocktable :block thisweek :step day > > Only two lines changed (1079 & 1082 of org-clock.el). Barely worthy > of a formal patch, but I have one attached. > > Adam > --- org-clock.el~ 2009-02-23 08:16:36.000000000 -0500 > +++ org-clock.el 2009-03-05 00:35:40.781250000 -0500 > @@ -1076,10 +1076,10 @@ > (while (< ts te) > (or (bolp) (insert "\n")) > (setq p1 (plist-put p1 :tstart (format-time-string > - (car org-time-stamp-formats) > + (org-time-stamp-format nil t) > (seconds-to-time ts)))) > (setq p1 (plist-put p1 :tend (format-time-string > - (car org-time-stamp-formats) > + (org-time-stamp-format nil t) > (seconds-to-time (setq ts (+ ts step)))))) > (insert "\n" (if (eq step0 'day) "Daily report: " "Weekly > report starting on: ") > (plist-get p1 :tstart) "\n") > _______________________________________________ > Emacs-orgmode mailing list > Remember: use `Reply All' to send replies to the list. > Emacs-orgmode@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-orgmode