Re: [PATCH] Change timestamps in day-step clocktable from active to inactive

From: Carsten Dominik <dominik@science.uva.nl>
To: Adam Elliott <aelliott@hgn.ca>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Change timestamps in day-step clocktable from active to inactive
Date: Thu, 5 Mar 2009 16:12:16 +0100	[thread overview]
Message-ID: <DF7B7E9F-3BFC-4383-B323-7340BD747C4A@uva.nl> (raw)
In-Reply-To: <49AF6A8E.3030908@hgn.ca>

Applied, thanks.

- Carsten

On Mar 5, 2009, at 7:00 AM, Adam Elliott wrote:

> When run in day-step mode, the clocktable header line for each day's  
> table contains an active timestamp.  I figure it should be an  
> inactive timestamp, since otherwise I get a junk entry in the agenda  
> each day (whatever heading was previous to the clocktable).
>
> I'm talking about the output from a spec such as the following:
>
> #+BEGIN: clocktable :block thisweek :step day
>
> Only two lines changed (1079 & 1082 of org-clock.el).  Barely worthy  
> of a formal patch, but I have one attached.
>
> Adam
> --- org-clock.el~	2009-02-23 08:16:36.000000000 -0500
> +++ org-clock.el	2009-03-05 00:35:40.781250000 -0500
> @@ -1076,10 +1076,10 @@
>     (while (< ts te)
>       (or (bolp) (insert "\n"))
>       (setq p1 (plist-put p1 :tstart (format-time-string
> -				      (car org-time-stamp-formats)
> +                                      (org-time-stamp-format nil t)
> 				      (seconds-to-time ts))))
>       (setq p1 (plist-put p1 :tend (format-time-string
> -				    (car org-time-stamp-formats)
> +                                    (org-time-stamp-format nil t)
> 				    (seconds-to-time (setq ts (+ ts step))))))
>       (insert "\n" (if (eq step0 'day) "Daily report: " "Weekly  
> report starting on: ")
> 	      (plist-get p1 :tstart) "\n")
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode