From: Carsten Dominik <carsten.dominik@gmail.com>
To: Mikael Fornius <mfo@abc.se>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org-set/delete-property
Date: Fri, 12 Mar 2010 18:26:45 +0100 [thread overview]
Message-ID: <DA43347D-8BC1-47D3-91DF-840617DA0FEE@gmail.com> (raw)
In-Reply-To: <874oklxy3k.fsf@eee.lan>
OK, done, thanks.
- Carsten
On Mar 12, 2010, at 6:13 PM, Mikael Fornius wrote:
> Carsten Dominik <carsten.dominik@gmail.com> writes:
>
>> are these changes relative to the current git version, or relative to
>> the state before your initial change?
>
> They are relative to the current git version, I make a new one.
>
> This is the change I would like to have applied if you agree:
>
> diff --git a/lisp/ChangeLog b/lisp/ChangeLog
> index 28febc1..417727e 100755
> --- a/lisp/ChangeLog
> +++ b/lisp/ChangeLog
> @@ -1,3 +1,8 @@
> +2010-03-12 Mikael Fornius <mfo@abc.se>
> +
> + * org.el (org-set-property, org-delete-property): Do not use
> + property at cursor but prompt always.
> +
> 2010-03-12 Carsten Dominik <carsten.dominik@gmail.com>
>
> * org-latex.el (org-export-latex-make-header): Fully process
> diff --git a/lisp/org.el b/lisp/org.el
> index a4932a2..72dfa9d 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -12986,8 +12986,7 @@ in the current file."
> (interactive
> (let* ((completion-ignore-case t)
> (keys (org-buffer-property-keys nil t t))
> - (prop0 (or (when (org-at-property-p) (org-match-string-no-
> properties 2))
> - (org-icompleting-read "Property: " (mapcar 'list keys))))
> + (prop0 (org-icompleting-read "Property: " (mapcar 'list keys)))
> (prop (if (member prop0 keys)
> prop0
> (or (cdr (assoc (downcase prop0)
> @@ -13014,9 +13013,7 @@ in the current file."
> "In the current entry, delete PROPERTY."
> (interactive
> (let* ((completion-ignore-case t)
> - (prop (or (when (org-at-property-p) (org-match-string-no-
> properties 2))
> - (org-icompleting-read
> - "Property: " (org-entry-properties nil 'standard)))))
> + (prop (org-icompleting-read "Property: " (org-entry-properties
> nil 'standard))))
> (list prop)))
> (message "Property %s %s" property
> (if (org-entry-delete nil property)
>
> Thanks!
>
> --
> Mikael Fornius
- Carsten
prev parent reply other threads:[~2010-03-12 17:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-11 12:49 [PATCH] org-at-property-p and related Mikael Fornius
2010-03-11 12:52 ` Mikael Fornius
2010-03-11 13:06 ` Mikael Fornius
2010-03-11 13:10 ` Carsten Dominik
2010-03-11 14:01 ` Mikael Fornius
2010-03-11 14:05 ` Carsten Dominik
2010-03-11 16:43 ` [PATCH] org-set/delete-property Mikael Fornius
2010-03-12 16:38 ` Carsten Dominik
2010-03-12 17:13 ` Mikael Fornius
2010-03-12 17:26 ` Carsten Dominik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DA43347D-8BC1-47D3-91DF-840617DA0FEE@gmail.com \
--to=carsten.dominik@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=mfo@abc.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).