From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: [PATCH] org-set/delete-property Date: Fri, 12 Mar 2010 18:26:45 +0100 Message-ID: References: <878w9zkopt.fsf@eee.lan> <874oknkoka.fsf@eee.lan> <87mxyfj9cl.fsf@eee.lan> <1B465F86-9D70-411F-93F7-E5EFE40BF0FA@gmail.com> <87iq93j6u1.fsf@eee.lan> <1783E925-8587-4FB1-A289-24C0FD7B1247@gmail.com> <87zl2ekdwe.fsf_-_@eee.lan> <3C4F914D-8D8E-44DF-8F0C-4D9A36BB0402@gmail.com> <874oklxy3k.fsf@eee.lan> Mime-Version: 1.0 (Apple Message framework v936) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nq8hx-0005d9-GB for emacs-orgmode@gnu.org; Fri, 12 Mar 2010 12:31:33 -0500 Received: from [140.186.70.92] (port=55930 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nq8hu-0005d1-57 for emacs-orgmode@gnu.org; Fri, 12 Mar 2010 12:31:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Nq8hs-0001bX-7r for emacs-orgmode@gnu.org; Fri, 12 Mar 2010 12:31:30 -0500 Received: from mail-ew0-f216.google.com ([209.85.219.216]:63636) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nq8hs-0001bD-3K for emacs-orgmode@gnu.org; Fri, 12 Mar 2010 12:31:28 -0500 Received: by ewy8 with SMTP id 8so404333ewy.8 for ; Fri, 12 Mar 2010 09:31:27 -0800 (PST) In-Reply-To: <874oklxy3k.fsf@eee.lan> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Mikael Fornius Cc: emacs-orgmode@gnu.org OK, done, thanks. - Carsten On Mar 12, 2010, at 6:13 PM, Mikael Fornius wrote: > Carsten Dominik writes: > >> are these changes relative to the current git version, or relative to >> the state before your initial change? > > They are relative to the current git version, I make a new one. > > This is the change I would like to have applied if you agree: > > diff --git a/lisp/ChangeLog b/lisp/ChangeLog > index 28febc1..417727e 100755 > --- a/lisp/ChangeLog > +++ b/lisp/ChangeLog > @@ -1,3 +1,8 @@ > +2010-03-12 Mikael Fornius > + > + * org.el (org-set-property, org-delete-property): Do not use > + property at cursor but prompt always. > + > 2010-03-12 Carsten Dominik > > * org-latex.el (org-export-latex-make-header): Fully process > diff --git a/lisp/org.el b/lisp/org.el > index a4932a2..72dfa9d 100644 > --- a/lisp/org.el > +++ b/lisp/org.el > @@ -12986,8 +12986,7 @@ in the current file." > (interactive > (let* ((completion-ignore-case t) > (keys (org-buffer-property-keys nil t t)) > - (prop0 (or (when (org-at-property-p) (org-match-string-no- > properties 2)) > - (org-icompleting-read "Property: " (mapcar 'list keys)))) > + (prop0 (org-icompleting-read "Property: " (mapcar 'list keys))) > (prop (if (member prop0 keys) > prop0 > (or (cdr (assoc (downcase prop0) > @@ -13014,9 +13013,7 @@ in the current file." > "In the current entry, delete PROPERTY." > (interactive > (let* ((completion-ignore-case t) > - (prop (or (when (org-at-property-p) (org-match-string-no- > properties 2)) > - (org-icompleting-read > - "Property: " (org-entry-properties nil 'standard))))) > + (prop (org-icompleting-read "Property: " (org-entry-properties > nil 'standard)))) > (list prop))) > (message "Property %s %s" property > (if (org-entry-delete nil property) > > Thanks! > > -- > Mikael Fornius - Carsten