emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Carsten Dominik <carsten.dominik@gmail.com>
To: Mikael Fornius <mfo@abc.se>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org-at-property-p and related
Date: Thu, 11 Mar 2010 15:05:03 +0100	[thread overview]
Message-ID: <1783E925-8587-4FB1-A289-24C0FD7B1247@gmail.com> (raw)
In-Reply-To: <87iq93j6u1.fsf@eee.lan>

Done, thanks...

- Carsten

On Mar 11, 2010, at 3:01 PM, Mikael Fornius wrote:

>
> Sorry, I did a little wrong again. It is not my day today...
>
> Please also apply this for correct behavior:
>
> diff --git a/lisp/org.el b/lisp/org.el
> index ad15d5e..a4932a2 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -12986,7 +12986,7 @@ in the current file."
>   (interactive
>    (let* ((completion-ignore-case t)
> 	  (keys (org-buffer-property-keys nil t t))
> -	  (prop0 (or (progn (org-at-property-p) (org-match-string-no- 
> properties 2))
> +	  (prop0 (or (when (org-at-property-p) (org-match-string-no- 
> properties 2))
> 		     (org-icompleting-read "Property: " (mapcar 'list keys))))
> 	  (prop (if (member prop0 keys)
> 		    prop0
> @@ -13014,7 +13014,7 @@ in the current file."
>   "In the current entry, delete PROPERTY."
>   (interactive
>    (let* ((completion-ignore-case t)
> -	  (prop (or (progn (org-at-property-p) (org-match-string-no- 
> properties 2))
> +	  (prop (or (when (org-at-property-p) (org-match-string-no- 
> properties 2))
> 		    (org-icompleting-read
> 		     "Property: " (org-entry-properties nil 'standard)))))
>      (list prop)))
>
> -- 
> Mikael Fornius

- Carsten

  reply	other threads:[~2010-03-11 14:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-11 12:49 [PATCH] org-at-property-p and related Mikael Fornius
2010-03-11 12:52 ` Mikael Fornius
2010-03-11 13:06   ` Mikael Fornius
2010-03-11 13:10     ` Carsten Dominik
2010-03-11 14:01       ` Mikael Fornius
2010-03-11 14:05         ` Carsten Dominik [this message]
2010-03-11 16:43           ` [PATCH] org-set/delete-property Mikael Fornius
2010-03-12 16:38             ` Carsten Dominik
2010-03-12 17:13               ` Mikael Fornius
2010-03-12 17:26                 ` Carsten Dominik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1783E925-8587-4FB1-A289-24C0FD7B1247@gmail.com \
    --to=carsten.dominik@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=mfo@abc.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).