From: Mikael Fornius <mfo@abc.se>
To: Carsten Dominik <carsten.dominik@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org-set/delete-property
Date: Fri, 12 Mar 2010 18:13:03 +0100 [thread overview]
Message-ID: <874oklxy3k.fsf@eee.lan> (raw)
In-Reply-To: <3C4F914D-8D8E-44DF-8F0C-4D9A36BB0402@gmail.com> (Carsten Dominik's message of "Fri, 12 Mar 2010 17:38:31 +0100")
[-- Attachment #1: Type: text/plain, Size: 294 bytes --]
Carsten Dominik <carsten.dominik@gmail.com> writes:
> are these changes relative to the current git version, or relative to
> the state before your initial change?
They are relative to the current git version, I make a new one.
This is the change I would like to have applied if you agree:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Always prompt for property name. --]
[-- Type: text/x-patch, Size: 1447 bytes --]
diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 28febc1..417727e 100755
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,8 @@
+2010-03-12 Mikael Fornius <mfo@abc.se>
+
+ * org.el (org-set-property, org-delete-property): Do not use
+ property at cursor but prompt always.
+
2010-03-12 Carsten Dominik <carsten.dominik@gmail.com>
* org-latex.el (org-export-latex-make-header): Fully process
diff --git a/lisp/org.el b/lisp/org.el
index a4932a2..72dfa9d 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -12986,8 +12986,7 @@ in the current file."
(interactive
(let* ((completion-ignore-case t)
(keys (org-buffer-property-keys nil t t))
- (prop0 (or (when (org-at-property-p) (org-match-string-no-properties 2))
- (org-icompleting-read "Property: " (mapcar 'list keys))))
+ (prop0 (org-icompleting-read "Property: " (mapcar 'list keys)))
(prop (if (member prop0 keys)
prop0
(or (cdr (assoc (downcase prop0)
@@ -13014,9 +13013,7 @@ in the current file."
"In the current entry, delete PROPERTY."
(interactive
(let* ((completion-ignore-case t)
- (prop (or (when (org-at-property-p) (org-match-string-no-properties 2))
- (org-icompleting-read
- "Property: " (org-entry-properties nil 'standard)))))
+ (prop (org-icompleting-read "Property: " (org-entry-properties nil 'standard))))
(list prop)))
(message "Property %s %s" property
(if (org-entry-delete nil property)
[-- Attachment #3: Type: text/plain, Size: 29 bytes --]
Thanks!
--
Mikael Fornius
[-- Attachment #4: Type: text/plain, Size: 201 bytes --]
_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode
next prev parent reply other threads:[~2010-03-12 17:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-11 12:49 [PATCH] org-at-property-p and related Mikael Fornius
2010-03-11 12:52 ` Mikael Fornius
2010-03-11 13:06 ` Mikael Fornius
2010-03-11 13:10 ` Carsten Dominik
2010-03-11 14:01 ` Mikael Fornius
2010-03-11 14:05 ` Carsten Dominik
2010-03-11 16:43 ` [PATCH] org-set/delete-property Mikael Fornius
2010-03-12 16:38 ` Carsten Dominik
2010-03-12 17:13 ` Mikael Fornius [this message]
2010-03-12 17:26 ` Carsten Dominik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874oklxy3k.fsf@eee.lan \
--to=mfo@abc.se \
--cc=carsten.dominik@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).