From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mikael Fornius Subject: Re: [PATCH] org-set/delete-property Date: Fri, 12 Mar 2010 18:13:03 +0100 Message-ID: <874oklxy3k.fsf@eee.lan> References: <878w9zkopt.fsf@eee.lan> <874oknkoka.fsf@eee.lan> <87mxyfj9cl.fsf@eee.lan> <1B465F86-9D70-411F-93F7-E5EFE40BF0FA@gmail.com> <87iq93j6u1.fsf@eee.lan> <1783E925-8587-4FB1-A289-24C0FD7B1247@gmail.com> <87zl2ekdwe.fsf_-_@eee.lan> <3C4F914D-8D8E-44DF-8F0C-4D9A36BB0402@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nq8Mq-0006bj-BI for emacs-orgmode@gnu.org; Fri, 12 Mar 2010 12:09:44 -0500 Received: from [140.186.70.92] (port=57545 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nq8Mo-0006a6-FV for emacs-orgmode@gnu.org; Fri, 12 Mar 2010 12:09:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Nq8Ml-0006sq-AV for emacs-orgmode@gnu.org; Fri, 12 Mar 2010 12:09:42 -0500 Received: from violet.abc.se ([62.80.200.155]:36853) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nq8Mk-0006m0-TY for emacs-orgmode@gnu.org; Fri, 12 Mar 2010 12:09:39 -0500 In-Reply-To: <3C4F914D-8D8E-44DF-8F0C-4D9A36BB0402@gmail.com> (Carsten Dominik's message of "Fri, 12 Mar 2010 17:38:31 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Carsten Dominik Cc: emacs-orgmode@gnu.org --=-=-= Carsten Dominik writes: > are these changes relative to the current git version, or relative to > the state before your initial change? They are relative to the current git version, I make a new one. This is the change I would like to have applied if you agree: --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=always-prompt.patch Content-Description: Always prompt for property name. diff --git a/lisp/ChangeLog b/lisp/ChangeLog index 28febc1..417727e 100755 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog @@ -1,3 +1,8 @@ +2010-03-12 Mikael Fornius + + * org.el (org-set-property, org-delete-property): Do not use + property at cursor but prompt always. + 2010-03-12 Carsten Dominik * org-latex.el (org-export-latex-make-header): Fully process diff --git a/lisp/org.el b/lisp/org.el index a4932a2..72dfa9d 100644 --- a/lisp/org.el +++ b/lisp/org.el @@ -12986,8 +12986,7 @@ in the current file." (interactive (let* ((completion-ignore-case t) (keys (org-buffer-property-keys nil t t)) - (prop0 (or (when (org-at-property-p) (org-match-string-no-properties 2)) - (org-icompleting-read "Property: " (mapcar 'list keys)))) + (prop0 (org-icompleting-read "Property: " (mapcar 'list keys))) (prop (if (member prop0 keys) prop0 (or (cdr (assoc (downcase prop0) @@ -13014,9 +13013,7 @@ in the current file." "In the current entry, delete PROPERTY." (interactive (let* ((completion-ignore-case t) - (prop (or (when (org-at-property-p) (org-match-string-no-properties 2)) - (org-icompleting-read - "Property: " (org-entry-properties nil 'standard))))) + (prop (org-icompleting-read "Property: " (org-entry-properties nil 'standard)))) (list prop))) (message "Property %s %s" property (if (org-entry-delete nil property) --=-=-= Thanks! -- Mikael Fornius --=-=-= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode --=-=-=--