From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: [PATCH] org-at-property-p and related Date: Thu, 11 Mar 2010 15:05:03 +0100 Message-ID: <1783E925-8587-4FB1-A289-24C0FD7B1247@gmail.com> References: <878w9zkopt.fsf@eee.lan> <874oknkoka.fsf@eee.lan> <87mxyfj9cl.fsf@eee.lan> <1B465F86-9D70-411F-93F7-E5EFE40BF0FA@gmail.com> <87iq93j6u1.fsf@eee.lan> Mime-Version: 1.0 (Apple Message framework v936) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Npj0g-0004Lk-89 for emacs-orgmode@gnu.org; Thu, 11 Mar 2010 09:05:10 -0500 Received: from [140.186.70.92] (port=59731 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Npj0f-0004L1-6g for emacs-orgmode@gnu.org; Thu, 11 Mar 2010 09:05:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Npj0e-00076K-6W for emacs-orgmode@gnu.org; Thu, 11 Mar 2010 09:05:08 -0500 Received: from mail-bw0-f219.google.com ([209.85.218.219]:42558) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Npj0e-00076A-0n for emacs-orgmode@gnu.org; Thu, 11 Mar 2010 09:05:08 -0500 Received: by bwz19 with SMTP id 19so50157bwz.26 for ; Thu, 11 Mar 2010 06:05:06 -0800 (PST) In-Reply-To: <87iq93j6u1.fsf@eee.lan> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Mikael Fornius Cc: emacs-orgmode@gnu.org Done, thanks... - Carsten On Mar 11, 2010, at 3:01 PM, Mikael Fornius wrote: > > Sorry, I did a little wrong again. It is not my day today... > > Please also apply this for correct behavior: > > diff --git a/lisp/org.el b/lisp/org.el > index ad15d5e..a4932a2 100644 > --- a/lisp/org.el > +++ b/lisp/org.el > @@ -12986,7 +12986,7 @@ in the current file." > (interactive > (let* ((completion-ignore-case t) > (keys (org-buffer-property-keys nil t t)) > - (prop0 (or (progn (org-at-property-p) (org-match-string-no- > properties 2)) > + (prop0 (or (when (org-at-property-p) (org-match-string-no- > properties 2)) > (org-icompleting-read "Property: " (mapcar 'list keys)))) > (prop (if (member prop0 keys) > prop0 > @@ -13014,7 +13014,7 @@ in the current file." > "In the current entry, delete PROPERTY." > (interactive > (let* ((completion-ignore-case t) > - (prop (or (progn (org-at-property-p) (org-match-string-no- > properties 2)) > + (prop (or (when (org-at-property-p) (org-match-string-no- > properties 2)) > (org-icompleting-read > "Property: " (org-entry-properties nil 'standard))))) > (list prop))) > > -- > Mikael Fornius - Carsten