* [PATCH] Use integer syntax for the MODE argument to #'set-file-modes
@ 2010-08-21 23:17 Aidan Kehoe
2010-08-23 10:08 ` Carsten Dominik
0 siblings, 1 reply; 2+ messages in thread
From: Aidan Kehoe @ 2010-08-21 23:17 UTC (permalink / raw)
To: emacs-orgmode
Hello!
We need this change to get org-mode compiling with recent XEmacs 21.5. On
previous 21.5 and current 21.4, the problem manifests itself at runtime, not
compile time, like so:
(set-file-modes "/tmp/aidan/foo.el" ?\755)
=> Wrong type argument: integerp, ?í
One old reason to go for the ?\755 syntax instead of the #o755 syntax under
GNU Emacs was to be that older versions of GNU Emacs didn’t support #o755,
but, to my knowledge, every released GNU Emacs since March 2000 has
supported the latter syntax.
Best,
Aidan Kehoe, the XEmacs project.
ChangeLog addition:
2010-08-21 Aidan Kehoe <kehoea@parhasard.net>
* ob-tangle.el (org-babel-tangle): Change the MODE argument to
#'set-file-modes to use integer, not character syntax, avoiding
compile problems with recent XEmacs.
diff --git a/lisp/ob-tangle.el b/lisp/ob-tangle.el
index a7ba072..adc054a 100644
--- a/lisp/ob-tangle.el
+++ b/lisp/ob-tangle.el
@@ -187,7 +187,7 @@ exported source code blocks by language."
(insert content)
(write-region nil nil file-name))))
;; if files contain she-bangs, then make the executable
- (when she-bang (set-file-modes file-name ?\755))
+ (when she-bang (set-file-modes file-name #o755))
;; update counter
(setq block-counter (+ 1 block-counter))
(add-to-list 'path-collector file-name)))))
--
“Apart from the nine-banded armadillo, man is the only natural host of
Mycobacterium leprae, although it can be grown in the footpads of mice.”
-- Kumar & Clark, Clinical Medicine, summarising improbable leprosy research
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Use integer syntax for the MODE argument to #'set-file-modes
2010-08-21 23:17 [PATCH] Use integer syntax for the MODE argument to #'set-file-modes Aidan Kehoe
@ 2010-08-23 10:08 ` Carsten Dominik
0 siblings, 0 replies; 2+ messages in thread
From: Carsten Dominik @ 2010-08-23 10:08 UTC (permalink / raw)
To: Aidan Kehoe; +Cc: emacs-orgmode
Applied, thanks.
- Carsten
On Sun, Aug 22, 2010 at 1:17 AM, Aidan Kehoe <kehoea@parhasard.net> wrote:
>
> Hello!
>
> We need this change to get org-mode compiling with recent XEmacs 21.5. On
> previous 21.5 and current 21.4, the problem manifests itself at runtime, not
> compile time, like so:
>
> (set-file-modes "/tmp/aidan/foo.el" ?\755)
> => Wrong type argument: integerp, ?í
>
> One old reason to go for the ?\755 syntax instead of the #o755 syntax under
> GNU Emacs was to be that older versions of GNU Emacs didn’t support #o755,
> but, to my knowledge, every released GNU Emacs since March 2000 has
> supported the latter syntax.
>
> Best,
>
> Aidan Kehoe, the XEmacs project.
>
> ChangeLog addition:
>
> 2010-08-21 Aidan Kehoe <kehoea@parhasard.net>
>
> * ob-tangle.el (org-babel-tangle): Change the MODE argument to
> #'set-file-modes to use integer, not character syntax, avoiding
> compile problems with recent XEmacs.
>
> diff --git a/lisp/ob-tangle.el b/lisp/ob-tangle.el
> index a7ba072..adc054a 100644
> --- a/lisp/ob-tangle.el
> +++ b/lisp/ob-tangle.el
> @@ -187,7 +187,7 @@ exported source code blocks by language."
> (insert content)
> (write-region nil nil file-name))))
> ;; if files contain she-bangs, then make the executable
> - (when she-bang (set-file-modes file-name ?\755))
> + (when she-bang (set-file-modes file-name #o755))
> ;; update counter
> (setq block-counter (+ 1 block-counter))
> (add-to-list 'path-collector file-name)))))
>
>
> --
> “Apart from the nine-banded armadillo, man is the only natural host of
> Mycobacterium leprae, although it can be grown in the footpads of mice.”
> -- Kumar & Clark, Clinical Medicine, summarising improbable leprosy research
>
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-08-23 10:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-08-21 23:17 [PATCH] Use integer syntax for the MODE argument to #'set-file-modes Aidan Kehoe
2010-08-23 10:08 ` Carsten Dominik
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).