From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aidan Kehoe Subject: [PATCH] Use integer syntax for the MODE argument to #'set-file-modes Date: Sun, 22 Aug 2010 00:17:04 +0100 Message-ID: <19568.24176.636168.145227@parhasard.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from [140.186.70.92] (port=34835 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OmxJF-00019W-JG for emacs-orgmode@gnu.org; Sat, 21 Aug 2010 19:17:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OmxJE-0005Ro-FR for emacs-orgmode@gnu.org; Sat, 21 Aug 2010 19:17:09 -0400 Received: from daedalus.ipv4.asclepian.ie ([213.133.100.226]:56349 helo=daedalus.asclepian.ie) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OmxJE-0005Rb-8C for emacs-orgmode@gnu.org; Sat, 21 Aug 2010 19:17:08 -0400 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Hello! We need this change to get org-mode compiling with recent XEmacs 21.5. On previous 21.5 and current 21.4, the problem manifests itself at runtime, = not compile time, like so: (set-file-modes "/tmp/aidan/foo.el" ?\755) =3D> Wrong type argument: integerp, ?=C3=AD One old reason to go for the ?\755 syntax instead of the #o755 syntax und= er GNU Emacs was to be that older versions of GNU Emacs didn=E2=80=99t suppo= rt #o755, but, to my knowledge, every released GNU Emacs since March 2000 has supported the latter syntax. Best, Aidan Kehoe, the XEmacs project.=20 ChangeLog addition: 2010-08-21 Aidan Kehoe * ob-tangle.el (org-babel-tangle): Change the MODE argument to #'set-file-modes to use integer, not character syntax, avoiding compile problems with recent XEmacs. diff --git a/lisp/ob-tangle.el b/lisp/ob-tangle.el index a7ba072..adc054a 100644 --- a/lisp/ob-tangle.el +++ b/lisp/ob-tangle.el @@ -187,7 +187,7 @@ exported source code blocks by language." (insert content) (write-region nil nil file-name)))) ;; if files contain she-bangs, then make the executable - (when she-bang (set-file-modes file-name ?\755)) + (when she-bang (set-file-modes file-name #o755)) ;; update counter (setq block-counter (+ 1 block-counter)) (add-to-list 'path-collector file-name))))) --=20 =E2=80=9CApart from the nine-banded armadillo, man is the only natural ho= st of Mycobacterium leprae, although it can be grown in the footpads of mice.=E2= =80=9D -- Kumar & Clark, Clinical Medicine, summarising improbable leprosy res= earch