From: Carsten Dominik <carsten.dominik@gmail.com>
To: Aidan Kehoe <kehoea@parhasard.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Use integer syntax for the MODE argument to #'set-file-modes
Date: Mon, 23 Aug 2010 12:08:08 +0200 [thread overview]
Message-ID: <AANLkTikic=a0_D28OL1wKW17CjUP4jYq-3YJenX_rXh3@mail.gmail.com> (raw)
In-Reply-To: <19568.24176.636168.145227@parhasard.net>
Applied, thanks.
- Carsten
On Sun, Aug 22, 2010 at 1:17 AM, Aidan Kehoe <kehoea@parhasard.net> wrote:
>
> Hello!
>
> We need this change to get org-mode compiling with recent XEmacs 21.5. On
> previous 21.5 and current 21.4, the problem manifests itself at runtime, not
> compile time, like so:
>
> (set-file-modes "/tmp/aidan/foo.el" ?\755)
> => Wrong type argument: integerp, ?í
>
> One old reason to go for the ?\755 syntax instead of the #o755 syntax under
> GNU Emacs was to be that older versions of GNU Emacs didn’t support #o755,
> but, to my knowledge, every released GNU Emacs since March 2000 has
> supported the latter syntax.
>
> Best,
>
> Aidan Kehoe, the XEmacs project.
>
> ChangeLog addition:
>
> 2010-08-21 Aidan Kehoe <kehoea@parhasard.net>
>
> * ob-tangle.el (org-babel-tangle): Change the MODE argument to
> #'set-file-modes to use integer, not character syntax, avoiding
> compile problems with recent XEmacs.
>
> diff --git a/lisp/ob-tangle.el b/lisp/ob-tangle.el
> index a7ba072..adc054a 100644
> --- a/lisp/ob-tangle.el
> +++ b/lisp/ob-tangle.el
> @@ -187,7 +187,7 @@ exported source code blocks by language."
> (insert content)
> (write-region nil nil file-name))))
> ;; if files contain she-bangs, then make the executable
> - (when she-bang (set-file-modes file-name ?\755))
> + (when she-bang (set-file-modes file-name #o755))
> ;; update counter
> (setq block-counter (+ 1 block-counter))
> (add-to-list 'path-collector file-name)))))
>
>
> --
> “Apart from the nine-banded armadillo, man is the only natural host of
> Mycobacterium leprae, although it can be grown in the footpads of mice.”
> -- Kumar & Clark, Clinical Medicine, summarising improbable leprosy research
>
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>
prev parent reply other threads:[~2010-08-23 10:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-21 23:17 [PATCH] Use integer syntax for the MODE argument to #'set-file-modes Aidan Kehoe
2010-08-23 10:08 ` Carsten Dominik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTikic=a0_D28OL1wKW17CjUP4jYq-3YJenX_rXh3@mail.gmail.com' \
--to=carsten.dominik@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=kehoea@parhasard.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).