emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Eric Abrahamsen <eric@ericabrahamsen.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: replace letf with cl-letf in org-mime
Date: Tue, 31 Mar 2015 12:42:11 +0200	[thread overview]
Message-ID: <87zj6txxbw.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87619iopdj.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Mon, 30 Mar 2015 16:34:16 +0800")

Hello,

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> Subject: [PATCH] org-mime.el: Avoid use of letf/cl-letf

Thank you. Some comments follow.

> +    (let* ((mp (lambda (p)) (org-entry-get nil p org-mime-use-property-inheritance))

It should be

  (mp (lambda (p) (org-entry-get ....)))

> +  (let ((bhook
> +	 (lambda (body fmt)
> +	   (let ((hook (intern (concat "org-mime-pre-"
> +				       (symbol-name fmt)
> +				       "-hook"))))
> +	     (if (> (eval `(length ,hook)) 0)
> +		 (with-temp-buffer
> +		   (insert body)
> +		   (goto-char (point-min))
> +		   (eval `(run-hooks ',hook))
> +		   (buffer-string))
> +	       body))))

Not really related to the patch but the `eval' in the definition above
looks wrong. Shouldn't it be

  (> (length hook) 0)

and

  (run-hooks hook)

?


Regards,

next prev parent reply	other threads:[~2015-03-31 10:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-22 13:56 replace letf with cl-letf in org-mime Eric Abrahamsen
2015-03-22 14:16 ` Nicolas Goaziou
2015-03-22 14:30   ` Eric Abrahamsen
2015-03-30  8:34   ` Eric Abrahamsen
2015-03-31 10:42     ` Nicolas Goaziou [this message]
2015-04-01  2:17       ` Eric Abrahamsen
2015-04-01 19:46         ` Nicolas Goaziou
2015-04-02  1:33           ` Eric Abrahamsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zj6txxbw.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=eric@ericabrahamsen.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).